Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Basics: improve random number examples #255
I noticed the random examples were quite short and didn't document range for floating point cases. Improved.
Caveat: this doesn't explain why the
Hi @dhardy,, thanks for taking interest!
Some of our examples (as well as the actual rand crate) certainly need more polish. We'd love to have you on board!
Here are some suggestions below (sorry for the terse form but I'm currently on holidays mobile only)
few more suggestions and a commit squash into a single one
Well it certainly takes a lot of effort and motivation considering I am juggling +10PR's while on vacation with only mobile at my disposal.
Each an every one is held under the same scrutiny in order to have consistent format and quality. Please note that while the presentation and form might not look like it the cookbook is aimed to become an official resource once its out of its pre-alpha stage.
I agree that contribution is painful at the moment (I guess some kind of guideline for the examples would help)
Well I would not call it "wasting" you are helping a lot. For instance I would certainly fix the examples myself if I had even a slightest notion that there is a problem in them.
We are thinking about the final form and format for cookbook and if anything, your problems and suggestions will have an impact on the final output.
I guess that this PR might go smother If we had discussed your suggestions prior to you making the actual work. But unfortunately I did lack the means to drive the conversation.
Sorry to have discouraged you :(
This looks great, @dhardy. Thanks. I rebased and merged it. I did change the language in the non-uniform distributions example to not reference previous examples. For the moment at least it is true that the examples are pretty independent, and it's pretty likely that the format of the book will change drastically before any kind of final release.
I do think it would be worth having a better narrative progression between examples so that it reads nicely as a book, leads the reader on a journey of some kind. This is great for now though - we're going to have to circle back for a big editing pass in the future.
Thanks for reviewing @budziq (but do feel free to take some time off while you are traveling).