Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Parse and increment a version string" example #305

Closed
wants to merge 10 commits into from

Conversation

Projects
None yet
2 participants
@convoliution
Copy link
Contributor

convoliution commented Sep 30, 2017

#283

I'm actually not certain if this follows best practices or even the intended goal of the example.
Feedback appreciated!

@convoliution

This comment has been minimized.

Copy link
Contributor Author

convoliution commented Sep 30, 2017

Potential points to note:

  • Changed name of example from "modify" to "increment" because incrementing is the only modification the crate enables.
  • Prematurely assigned the semver crate to the Configuration category; the crate is not currently in any category, though I have mentioned this on the crate's evaluation thread!
  • Not entirely sure if I'm implementing error-chain correctly...

@budziq budziq changed the title Add "Parse and modify a version string" example Add "Parse and increment a version string" example Sep 30, 2017

@budziq

This comment has been minimized.

Copy link
Collaborator

budziq commented Sep 30, 2017

That's excellent work @mykalu !
I've merged it after minimal cleanup (squashed commits into single one, small wording update and moved the the external reference link to the bottom of the file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.