Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd num_cpus example #307
Conversation
budziq
requested changes
Sep 30, 2017
| # extern crate error_chain; | ||
| extern crate num_cpus; | ||
| # | ||
| # error_chain! { |
This comment has been minimized.
This comment has been minimized.
budziq
Sep 30, 2017
Collaborator
No need for error_chain as there is no possibility for error handling in this example. Lets just remove it.
|
|
||
| [![num_cpus-badge]][num_cpus] [![cat-hardware-support-badge]][cat-hardware-support] | ||
|
|
||
| Counts the number of logical cpu cores in current machine. |
This comment has been minimized.
This comment has been minimized.
budziq
Sep 30, 2017
Collaborator
I would rephrase that with something along the lines of:
"Shows the number of logical cpu cores with help of num_cpus::get" and I would hyperlink the symbol reference to its respective docs.rs
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
also please refer the original issue in your PR text like "fixes #307" for the issue to autoclose on this PR being merged |
This comment has been minimized.
This comment has been minimized.
|
merged with some minor cleanup. Thanks @V1shvesh |
budziq
closed this
Oct 1, 2017
This comment has been minimized.
This comment has been minimized.
|
@budziq I'm sorry for asking, but I'm seeing "closed pull request" instead of "merged pull request". This is fine, or not? |
This comment has been minimized.
This comment has been minimized.
|
Yeah, I've pulled your changes and done some minor finish line cleaning myself and pushed them directly. Github is not able to handle this correctly so one has to close the PR by hand. You can see your example in the gitlog (your authorship preserved) and published in rendered cookbook now |
This comment has been minimized.
This comment has been minimized.
|
Oh, that's not a problem. My main concern is would this count as a PR for hacktoberfest? |
This comment has been minimized.
This comment has been minimized.
|
No idea, sorry! But you can ask digital ocean directly. They are usually quite responsive. |
V1shvesh commentedSep 30, 2017
•
edited
@budziq have a look
Edit: fixes #307