Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add num_cpus example #307

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@V1shvesh
Copy link
Contributor

V1shvesh commented Sep 30, 2017

@budziq have a look
Edit: fixes #307

@budziq
Copy link
Collaborator

budziq left a comment

@V1shvesh the PR is almost perfect, just osme final touches

# extern crate error_chain;
extern crate num_cpus;
#
# error_chain! {

This comment has been minimized.

@budziq

budziq Sep 30, 2017

Collaborator

No need for error_chain as there is no possibility for error handling in this example. Lets just remove it.


[![num_cpus-badge]][num_cpus] [![cat-hardware-support-badge]][cat-hardware-support]

Counts the number of logical cpu cores in current machine.

This comment has been minimized.

@budziq

budziq Sep 30, 2017

Collaborator

I would rephrase that with something along the lines of:
"Shows the number of logical cpu cores with help of num_cpus::get" and I would hyperlink the symbol reference to its respective docs.rs

This comment has been minimized.

@V1shvesh

V1shvesh Oct 1, 2017

Author Contributor

I hope the heading is fine as it is.

@budziq

This comment has been minimized.

Copy link
Collaborator

budziq commented Sep 30, 2017

also please refer the original issue in your PR text like "fixes #307" for the issue to autoclose on this PR being merged

@budziq

This comment has been minimized.

Copy link
Collaborator

budziq commented Oct 1, 2017

merged with some minor cleanup. Thanks @V1shvesh

@budziq budziq closed this Oct 1, 2017

@V1shvesh

This comment has been minimized.

Copy link
Contributor Author

V1shvesh commented Oct 2, 2017

@budziq I'm sorry for asking, but I'm seeing "closed pull request" instead of "merged pull request". This is fine, or not?

@budziq

This comment has been minimized.

Copy link
Collaborator

budziq commented Oct 2, 2017

Yeah, I've pulled your changes and done some minor finish line cleaning myself and pushed them directly. Github is not able to handle this correctly so one has to close the PR by hand.

You can see your example in the gitlog (your authorship preserved) and published in rendered cookbook now 👍

@V1shvesh

This comment has been minimized.

Copy link
Contributor Author

V1shvesh commented Oct 2, 2017

Oh, that's not a problem. My main concern is would this count as a PR for hacktoberfest?

@budziq

This comment has been minimized.

Copy link
Collaborator

budziq commented Oct 2, 2017

No idea, sorry! But you can ask digital ocean directly. They are usually quite responsive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.