Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upadd "Sign and verify a message with HMAC digest" example #314
Conversation
budziq
added
claimed
and removed
claimed
labels
Oct 4, 2017
This comment has been minimized.
This comment has been minimized.
|
Hi @Yarn, Your PR has merge conflicts with master. Could you squash and rebase it against master? |
Yarn
force-pushed the
Yarn:master
branch
2 times, most recently
from
a225106
to
3d23e03
Oct 4, 2017
This comment has been minimized.
This comment has been minimized.
|
I have communed with the elder gods and achieved an A E S T H E T I C git history. |
budziq
requested changes
Oct 4, 2017
src/basics.md
Outdated
| <a name="ex-hmac"></a> | ||
| ## Sign and verify a message with HMAC digest | ||
|
|
||
| [![ring-badge]][ring] [![data-encoding-badge]][data-encoding] [![cat-cryptography-badge]][cat-cryptography] |
This comment has been minimized.
This comment has been minimized.
src/basics.md
Outdated
| extern crate ring; | ||
| # | ||
| # #[macro_use] | ||
| # extern crate error_chain; |
This comment has been minimized.
This comment has been minimized.
budziq
Oct 4, 2017
Collaborator
for the sake of consistency with other examples i would suggest to put error_chain as the first extern crate without newlines below
src/basics.md
Outdated
| Ok(()) | ||
| } | ||
This comment has been minimized.
This comment has been minimized.
budziq
Oct 4, 2017
Collaborator
lets add the # here to avoid trailing newline when example is collapsed.
src/basics.md
Outdated
|
|
||
| [![ring-badge]][ring] [![data-encoding-badge]][data-encoding] [![cat-cryptography-badge]][cat-cryptography] | ||
|
|
||
| Creates a [`hmac::Signature`] of a string then verifies the signiture is correct. |
This comment has been minimized.
This comment has been minimized.
budziq
Oct 4, 2017
Collaborator
I would suggest adding other hyperlinked identifiers to the description for the benefit of the reader.
Yarn
force-pushed the
Yarn:master
branch
from
3d23e03
to
03776ce
Oct 6, 2017
This comment has been minimized.
This comment has been minimized.
|
made the suggested changes |
budziq
merged commit 525c3b6
into
rust-lang-nursery:master
Oct 7, 2017
This comment has been minimized.
This comment has been minimized.
|
Nicely done @Yarn ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Yarn commentedOct 4, 2017
•
edited by budziq
fixes #289