Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMatch semver crate examples' styling #315
Conversation
budziq
requested changes
Oct 4, 2017
|
thanks @mykalu! two minor suggestions. And you are welcome to update the other example to conform with this one. |
| release.increment_patch(); | ||
| assert_eq!(release, Version::parse("0.2.7")?); | ||
| assert_eq!("0.2.7", release.to_string()); |
This comment has been minimized.
This comment has been minimized.
budziq
Oct 4, 2017
Collaborator
If I were to mark my preference here I would suggest putting the hardcoded string against we are testing on the right.
I probably liked your original version better but it's a matter of taste, so I'll let you chose.
| pre: vec!(), | ||
| build: vec!(), | ||
| }); | ||
| let version_str = "0.2.6"; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
convoliution
Oct 4, 2017
•
Author
Contributor
Hmmm you're right; I separated it to match the other example, but there's no practical reason for it in this example.
convoliution
changed the title
Cleanup 'Parse and increment version string' styling
Match semver crate examples' styling
Oct 4, 2017
This comment has been minimized.
This comment has been minimized.
|
Suggestions implemented! Hmm, I'm using I feel that's a styling mismatch. Also concerned about the nomenclature difference between using @FaultyRAM do you have any thoughts on this? :D |
This comment has been minimized.
This comment has been minimized.
|
I would say that clarity+conciseness of given examples are more important tan total stylistic regime. Also I feel that |
This comment has been minimized.
This comment has been minimized.
|
Suggestions implemented! |
budziq
merged commit 5d41607
into
rust-lang-nursery:master
Oct 4, 2017
This comment has been minimized.
This comment has been minimized.
|
thanks! |
convoliution commentedOct 4, 2017
At the risk of bikeshedding, I revised the styling I used for #305 to match the styling used in #308.
Probably not even necessary, though. Feelings will not be hurt if the request is closed :')
(should I have opened an issue before PR'ing?)