Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate examples with "for_each" #334
Conversation
budziq
requested changes
Oct 16, 2017
src/basics.md
Outdated
| @@ -310,7 +310,7 @@ fn run() -> Result<()> { | |||
| (.*) # The commit message")?; | |||
| let stdout = String::from_utf8(output.stdout)?; | |||
| let commits = stdout | |||
| stdout | |||
This comment has been minimized.
This comment has been minimized.
budziq
Oct 16, 2017
Collaborator
we can get rid of the intermediate temp variables such as stdout here
sb89
force-pushed the
sb89:for_each
branch
from
a6d5645
to
f596806
Oct 16, 2017
This comment has been minimized.
This comment has been minimized.
|
Implemented changes as requested. |
budziq
merged commit 02ed855
into
rust-lang-nursery:master
Oct 17, 2017
This comment has been minimized.
This comment has been minimized.
|
Well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sb89 commentedOct 15, 2017
Fixes #332