Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing log4rs badge to intro #353

Merged
merged 1 commit into from Nov 2, 2017

Conversation

Projects
None yet
2 participants
@cschneid
Copy link
Contributor

cschneid commented Nov 1, 2017

The "Log messages to a custom location" item on the intro page had only
the log badge, but was missing the log4rs badge. The log4rs badge
was already present on the recipe.


Things to check before submitting a PR

  • the tests are passing locally with cargo test
  • cookbook renders correctly in mdbook serve -o
  • commits are squashed into one and rebased to latest master
  • PR contains correct "fixes #ISSUE_ID" clause to autoclose the issue once PR is merged
  • non rendered items are in sorted order (links, reference, identifiers, Cargo.toml)
  • links to docs.rs have wildcard version
  • code identifiers in description are in hyperlinked backticks
[`Entry::unpack`]: https://docs.rs/tar/*/tar/struct.Entry.html#method.unpack

Things to do after submitting PR

  • check if CI is happy with your PR
  • drop a comment on #209 if you consent to repository being relicensed with CC0 license 👍
Add a missing log4rs badge to intro
The "Log messages to a custom location" item on the intro page had only
the `log` badge, but was missing the `log4rs` badge. The `log4rs` was
already present on the specific recipe.
@budziq

This comment has been minimized.

Copy link
Collaborator

budziq commented Nov 2, 2017

@cschneid Thanks!

Please drop a comment on #209 if you consent to repository being relicensed with CC0 license!

@budziq budziq merged commit 3ea6f1f into rust-lang-nursery:master Nov 2, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@budziq

This comment has been minimized.

Copy link
Collaborator

budziq commented Nov 2, 2017

I also noticed that the table in logging.md also misses the log4rs badge would you consider making the PR here too?

@cschneid cschneid referenced this pull request Nov 2, 2017

Closed

Cookbook should probably be CC0 licensed #209

57 of 57 tasks complete

cschneid added a commit to cschneid/rust-cookbook that referenced this pull request Nov 2, 2017

Add missing log4s badge at top of Logging.md
Same issue as rust-lang-nursery#353, just another missed spot

@budziq noticed - thanks :)

cschneid added a commit to cschneid/rust-cookbook that referenced this pull request Nov 2, 2017

Add missing log4s badge at top of Logging.md
Same issue as rust-lang-nursery#353, just another missed spot

@budziq noticed - thanks :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.