Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a missing log4rs badge to intro #353
Conversation
This comment has been minimized.
This comment has been minimized.
budziq
merged commit 3ea6f1f
into
rust-lang-nursery:master
Nov 2, 2017
This comment has been minimized.
This comment has been minimized.
|
I also noticed that the table in logging.md also misses the log4rs badge would you consider making the PR here too? |
cschneid
referenced this pull request
Nov 2, 2017
Closed
Cookbook should probably be CC0 licensed #209
cschneid
added a commit
to cschneid/rust-cookbook
that referenced
this pull request
Nov 2, 2017
cschneid
added a commit
to cschneid/rust-cookbook
that referenced
this pull request
Nov 2, 2017
cschneid
referenced this pull request
Nov 2, 2017
Merged
Add missing log4s badge at top of Logging.md #354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
cschneid commentedNov 1, 2017
•
edited
The "Log messages to a custom location" item on the intro page had only
the
logbadge, but was missing thelog4rsbadge. Thelog4rsbadgewas already present on the recipe.
Things to check before submitting a PR
cargo testmdbook serve -o[`Entry::unpack`]: https://docs.rs/tar/*/tar/struct.Entry.html#method.unpackThings to do after submitting PR