Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `token-stream-stress` benchmark. #516

Merged

Conversation

@nnethercote
Copy link
Member

nnethercote commented Oct 18, 2019

This will prevent the fix in rust-lang/rust#65198 from regressing.

The benchmark is quite short-running, taking roughly 3x the time of helloworld. That's more than enough to detect regressions; prior to the fix it would have taken more than 100x longer.

@dtolnay, @alexcrichton: this benchmark is based on this test case. I hope that is ok. Let me know if you have ideas on how to improve this.

@nnethercote nnethercote force-pushed the nnethercote:add-token-stream-stress branch from 190fd65 to a85d63d Oct 19, 2019
@nnethercote

This comment has been minimized.

Copy link
Member Author

nnethercote commented Oct 19, 2019

@Mark-Simulacrum: I have removed the runs=1 line from the perf-config.json file.

@Mark-Simulacrum

This comment has been minimized.

Copy link
Collaborator

Mark-Simulacrum commented Oct 19, 2019

Will merge once CI verifies this works (it will pass either way, but manual inspection of the log is possible).

@Mark-Simulacrum

This comment has been minimized.

Copy link
Collaborator

Mark-Simulacrum commented Oct 19, 2019

Uh, looks like CI actually failed -- probably a trailing comma in the perf config?

@nnethercote nnethercote force-pushed the nnethercote:add-token-stream-stress branch from a85d63d to 2e3953f Oct 19, 2019
@nnethercote

This comment has been minimized.

Copy link
Member Author

nnethercote commented Oct 19, 2019

New version, with trailing comma removed.

@Mark-Simulacrum Mark-Simulacrum merged commit 82df64b into rust-lang-nursery:master Oct 20, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.