Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker: Release 1.0 #113

Closed
10 of 11 tasks
KodrAus opened this issue Jan 24, 2018 · 17 comments · Fixed by #596
Closed
10 of 11 tasks

Tracker: Release 1.0 #113

KodrAus opened this issue Jan 24, 2018 · 17 comments · Fixed by #596
Milestone

Comments

@KodrAus
Copy link
Member

KodrAus commented Jan 24, 2018

This is a list of things we need to do before we can release a stable version of uuid.

@KodrAus
Copy link
Member Author

KodrAus commented Jan 24, 2018

@alexcrichton does that list look right to you?

@alexcrichton
Copy link
Contributor

Heh I'd actually skip the last 3 steps even :)

I think it's fine to bump to 1.0 without an RFC of shifting to rust-lang, nowadays crates in the nursery tend to be relatively independent I think. We could always consult @rust-lang/libs to see if anyone disagrees!

@sfackler
Copy link
Contributor

I would prefer moving uuid out of rust-lang* rather than into rust-lang.

@KodrAus
Copy link
Member Author

KodrAus commented Jan 25, 2018

@sfackler I think I would too. Do you have any thoughts on where it should end up living?

@sfackler
Copy link
Contributor

In the hands of someone that cares about it, I guess.

@durka
Copy link

durka commented Jan 26, 2018

The next breaking release should have the std feature on by default, IMO.

@kinggoesgaming kinggoesgaming added this to the 1.0 milestone Jan 30, 2018
@kinggoesgaming kinggoesgaming changed the title Release 1.0 Tracker: Release 1.0 Feb 3, 2018
@kinggoesgaming kinggoesgaming added this to In progress in Uuid v1.0.0 Feb 3, 2018
@kinggoesgaming kinggoesgaming removed this from In progress in Uuid v1.0.0 Jul 31, 2018
@KodrAus
Copy link
Member Author

KodrAus commented Feb 8, 2019

cc @kinggoesgaming @Dylan-DPC

What do you think we need to resolve here in uuid before we're comfortable shipping a 1.0?

@Dylan-DPC-zz
Copy link
Member

i don't think there is anything major left. We can release the next major as 1.0

@kinggoesgaming
Copy link
Member

I think we will target 0.8 as a catch release just to ensure we didn't miss something... If everything goes good and dandy we might just bump the version of it as 1.0

@WiSaGaN
Copy link

WiSaGaN commented Feb 10, 2020

Greetings!
Is the 1.0 release planned this year, or is there anything further we are going to wait to include since the 0.8 release?

@kinggoesgaming
Copy link
Member

Hi @WiSaGaN, we are currently waiting on getting the points in #191 checked off. That's essentially all that is blocking 1.0 release.

There are a few breaking changes, they are not major enough to warrant a breaking minor release before 1.0 so they may be published under 1.0

@KodrAus KodrAus pinned this issue Aug 16, 2021
@KodrAus
Copy link
Member Author

KodrAus commented Aug 16, 2021

We've been carrying this along for a couple years now and had a chance to explore some APIs more deeply. I think the best way to solidify confidence in the API now would be to write up something like the regex RFC for the complete public surface area, including any more changes we wanted to make. I'll spend some time on this over the next little while.

I don't think it would be worth publishing any more minor releases before 1.0, like @kinggoesgaming mentioned there isn't much else we were looking at changing, and since uuid does appear publicly in consumer APIs we should limit any more incompatible versions floating around.

@KodrAus KodrAus removed the Tracker label Oct 28, 2021
@KodrAus
Copy link
Member Author

KodrAus commented Oct 29, 2021

I’m covering off the last breaking bits in #536. I’d like to be sure we can support #523 using our existing timestamp APIs and move winapi support into an external crate, but besides that I think we’re in good shape to stabilize.

@KodrAus
Copy link
Member Author

KodrAus commented Nov 1, 2021

Not much left now. We’ve just got #537 as a breaking change and need to get a release of the new proc macro ready.

Then we can do a 1.0.0-alpha to make sure everything is good for everyone and then stabilize this library!

@KodrAus
Copy link
Member Author

KodrAus commented Nov 18, 2021

We've now got a pre-release of 1.0.0 🎉

It'll be great to get the tyres kicking on this so we can weed out any potential issues, but unless breaking changes are necessary there won't be any difference between this release and what's stabilized as 1.0.0.

@jplatte
Copy link
Contributor

jplatte commented Nov 20, 2021

I saw in the pre-release changelog that a new get_foo method was added (well, renamed from to_foo). This seems to be against the Rust API guidelines.

@KodrAus
Copy link
Member Author

KodrAus commented Nov 21, 2021

Yeh, that one was a niche method renamed to fit the scheme of existing methods that have been around for a long time and predate the guidelines altogether. As far as transgressions goes it’s pretty mild since it doesn’t materially affect the program. So I opted to keep a consistent scheme with minimal churn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants