Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upinitial meeting notes #14
Conversation
qmx
force-pushed the
qmx:meeting-20181114
branch
from
117ee4b
to
08cd56f
Nov 17, 2018
This comment has been minimized.
This comment has been minimized.
|
Hmm, I was imagining we'd end up with an issue with checkboxes for action items. |
This comment has been minimized.
This comment has been minimized.
|
@eddyb we definitely can do that - I just want to make sure I've captured things correctly first :) |
| - eddyb thinks that's too early to discuss this, we're punting this to the near future | ||
| 4. GLL | ||
| - formatting | ||
| - we asked for small changes on the overall feel for GLL grammars, [GLL PR](https://github.com/lykenware/gll/pull/74) with the proposed changes. |
This comment has been minimized.
This comment has been minimized.
Centril
Nov 20, 2018
Contributor
should note what those were:
FnArgs =
| Regular:FnArg+ % ","
| Variadic:"..."
| RegularAndVariadic:{ args:FnArg+ % "," "," "..." }
;i.e. leading | and then just moving | to the start of line.
| - we asked for small changes on the overall feel for GLL grammars, [GLL PR](https://github.com/lykenware/gll/pull/74) with the proposed changes. | ||
| - syntax changes | ||
| - there were some discussions about using BNF-like `::=` for attribution of new rules but this went nowhere at least for now. | ||
|
|
This comment has been minimized.
This comment has been minimized.
qmx
added some commits
Jan 12, 2019
Centril
approved these changes
Jan 12, 2019
qmx
merged commit 57db91f
into
rust-lang-nursery:master
Jan 13, 2019
qmx
deleted the
qmx:meeting-20181114
branch
Jan 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
qmx commentedNov 17, 2018
No description provided.