/blog.rust-lang.org

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are missing in blog posts #312

Closed
badboy opened this Issue Dec 6, 2018 · 3 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@badboy @steveklabnik @sondr3
@badboy
Member

badboy commented Dec 6, 2018

Images are missing in blog posts, e.g. in the survey results: https://blog.rust-lang.org/2018/11/27/Rust-survey-2018.html
@steveklabnik

This comment has been minimized.

Sign in to view
Member

steveklabnik commented Dec 8, 2018

Hmm something must have happened at the last second because I certainly tested this. Thanks.
@sondr3

This comment has been minimized.

Sign in to view
Contributor

sondr3 commented Dec 10, 2018

Fairly certain this happened in #299, you can see all the images are removed in the files changed pane.

@steveklabnik steveklabnik closed this in 63f9304 Dec 11, 2018

@steveklabnik

This comment has been minimized.

Sign in to view
Member

steveklabnik commented Dec 11, 2018

I forgot -r when cping the images over, so the top-level images were there, but not ones in subdirectories. when i checked to see if images were working, I happened to pick a post that didn't use nested images, and so it worked for me.

I've added the missing images back; this should be deployed in a few minutes. Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment