Skip to content

/blog.rust-lang.org

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft of 1.24 announcement #228

Merged
merged 2 commits into from Feb 15, 2018

Conversation

Reviewers

@aturon aturon

@nrc nrc

@michaelwoerister michaelwoerister

@mgattozzi mgattozzi

@carols10cents carols10cents

@Mark-Simulacrum Mark-Simulacrum

Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
8 participants
@steveklabnik @rust-highfive @carols10cents @aturon @nrc @michaelwoerister @mgattozzi @Mark-Simulacrum
@steveklabnik
Copy link
Member

steveklabnik commented Feb 13, 2018

No description provided.

@steveklabnik
Draft of 1.24
Loading status checks…
aa44f3d

@rust-highfive rust-highfive assigned aturon Feb 13, 2018

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link

rust-highfive commented Feb 13, 2018

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)
@steveklabnik

This comment has been minimized.

Sign in to view
Copy link
Member Author

steveklabnik commented Feb 13, 2018

@rust-lang/core please review!
@Mark-Simulacrum

Mark-Simulacrum approved these changes Feb 13, 2018
View changes

Copy link
Member

Mark-Simulacrum left a comment

This looks good to me. We may want to add something about the cargo working directory breakage, but I'm not too worried about it.
_posts/2018-02-15-Rust-1.24.md
This is still not the end story for compiler performance generally, nor incremental compilation
specifically. We have a lot more work planned in the future. For example, another change
related to performance hit stable this release:
[`codegen-units` is now set to 16 by default](https://github.com/rust-lang/rust/pull/46910).

This comment has been minimized.

Sign in to view
Copy link
@Mark-Simulacrum

Mark-Simulacrum Feb 13, 2018

Member

It might be worth mentioning that this will likely make builds faster, but final products slower.
@carols10cents

carols10cents requested changes Feb 13, 2018
View changes

Copy link
Member

carols10cents left a comment

One tiny little misspelling to fix, content looks great! ❤️
_posts/2018-02-15-Rust-1.24.md Outdated
> the compiler, like the RLS and Clippy, in the future.
Finally, please take note of that `-preview` in the name: `rustfmt` is still not quite
at 1.0 yet. Some tweaks to the default styles are still occuring, though they're relatively

This comment has been minimized.

Sign in to view
Copy link
@carols10cents

carols10cents Feb 13, 2018

Member

s/occuring/occurring/
@mgattozzi

mgattozzi reviewed Feb 14, 2018
View changes

_posts/2018-02-15-Rust-1.24.md Outdated

### Library stabilizations

If you're a fan of `str::find`, used to find a given `char` inside of a `&str`, you'll be

This comment has been minimized.

Sign in to view
Copy link
@mgattozzi

mgattozzi Feb 14, 2018

Member

Might want to put which is in front of used. I had to reread the sentence a few times thinking the wording was a typo
@michaelwoerister

michaelwoerister reviewed Feb 14, 2018
View changes

_posts/2018-02-15-Rust-1.24.md Outdated

#### Incremental compilation

Back in September, we blogged about [Incremental Compilation](https://blog.rust-lang.org/2016/09/08/incremental.html).

This comment has been minimized.

Sign in to view
Copy link
@michaelwoerister

michaelwoerister Feb 14, 2018

Contributor

Note that this post is from September 2016 (!) already.

This comment has been minimized.

Sign in to view
Copy link
@aturon

aturon Feb 15, 2018

Member

Can we say anything about the expected performance wins?

This comment has been minimized.

Sign in to view
Copy link
@michaelwoerister

michaelwoerister Feb 15, 2018

Contributor

It very much depends on what you are compiling and what changes you made. "twice as fast" seems to be a good bet, looking at http://perf.rust-lang.org. For cargo check it might be different (better, hopefully) but we don't track that on perf.rlo yet.
@aturon

aturon reviewed Feb 15, 2018
View changes

_posts/2018-02-15-Rust-1.24.md Outdated
changed, which means that that second build is faster.

As of Rust 1.24, this is now [turned on by default](https://github.com/rust-lang/cargo/pull/4817).
This means that your builds should get faster!

This comment has been minimized.

Sign in to view
Copy link
@aturon

aturon Feb 15, 2018

Member

We should mention that cargo check should be used to get the best possible edit-compile cycle; can reference previous release announcement about that. I don't think we've done enough advertising of this as the recommended workflow.

This comment has been minimized.

Sign in to view
Copy link
@michaelwoerister

michaelwoerister Feb 15, 2018

Contributor

Also, do we have documentation somewhere that says when cargo defaults to incr. comp. and when it doesn't?

This comment has been minimized.

Sign in to view
Copy link
@steveklabnik

steveklabnik Feb 15, 2018

Author Member

i don't believe we do
@nrc

nrc reviewed Feb 15, 2018
View changes

_posts/2018-02-15-Rust-1.24.md Outdated
`rustup update stable`, `rustfmt-preview` will be updated as well.

> This strategy is expected to be used for other developer tools that integrate tightly with
> the compiler, like the RLS and Clippy, in the future.

This comment has been minimized.

Sign in to view
Copy link
@nrc

nrc Feb 15, 2018

Member

We already do this for RLS

This comment has been minimized.

Sign in to view
Copy link
@steveklabnik

steveklabnik Feb 15, 2018

Author Member

yeah, but we've never talked about it before, so i phrased it that way
_posts/2018-02-15-Rust-1.24.md Outdated
at 1.0 yet. Some tweaks to the default styles are still occuring, though they're relatively
minor. Once `rustfmt` hits 1.0, we'll be releasing a `rustfmt` component and
deprecating `rustfmt-preview`. Since this is the first major component we're distributing
this way, we wanted to clearly signal that it is still developing.

This comment has been minimized.

Sign in to view
Copy link
@nrc

nrc Feb 15, 2018

Member

MIght want to say something about this will happen without any user interaction - rustup will handle it.

This comment has been minimized.

Sign in to view
Copy link
@nrc

nrc Feb 15, 2018

Member

Oh, and it's the second component - you also have to use rls-preview

This comment has been minimized.

Sign in to view
Copy link
@steveklabnik

steveklabnik Feb 15, 2018

Author Member

same as above; we've never talked about rls-preview
_posts/2018-02-15-Rust-1.24.md Outdated
deprecating `rustfmt-preview`. Since this is the first major component we're distributing
this way, we wanted to clearly signal that it is still developing.

For more, please check out [`rustfmt` on GitHub](https://github.com/rust-lang-nursery/rustfmt).

This comment has been minimized.

Sign in to view
Copy link
@nrc

nrc Feb 15, 2018

Member

Might be good to say that if you've previously installed rustfmt with Cargo then you'll have to remove it, but that rustup should tell you about that.
@steveklabnik
feedback
Loading status checks…
8143bd8
@steveklabnik

This comment has been minimized.

Sign in to view
Copy link
Member Author

steveklabnik commented Feb 15, 2018

updated to incorporate everyone's feedback

@steveklabnik steveklabnik merged commit c772723 into gh-pages Feb 15, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@steveklabnik steveklabnik deleted the 1.24-announcement branch Feb 15, 2018

@steveklabnik steveklabnik restored the 1.24-announcement branch Mar 1, 2018

@steveklabnik steveklabnik deleted the 1.24-announcement branch Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.