Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Improving async-await's "Future is not Send" diagnostic" post. #418

Merged

Conversation

@davidtwco
Copy link
Member

davidtwco commented Oct 11, 2019

Requested by @nikomatsakis.

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Oct 11, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@davidtwco davidtwco force-pushed the davidtwco:async-await-not-send-error-blog-post branch from b66e615 to 663ac98 Oct 11, 2019
@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Oct 11, 2019

@nikomatsakis nikomatsakis merged commit b6093e1 into rust-lang:master Oct 11, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@davidtwco davidtwco deleted the davidtwco:async-await-not-send-error-blog-post branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.