Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort posts as YYYY-MM-DD-TITLE, not YYYY-M-D-TITLE #501

Conversation

@bobrik
Copy link
Contributor

bobrik commented Jan 26, 2020

Previously all December, November and October posts were buried
below February, because 2019/2/1 (Feb 1) is lexicographically
above (in front of?) 2019/10/1 (Oct 1). This is not how mother
nature intended it in ISO8601:

Let's correct this mistake by sorting dates with zero prefixed
month and day numbers to make all dates of fixed size.

Among other things, this puts Rust 1.40 (released 2019-12-19)
as the version newer than Rust 1.38 (released 2019-09-26),
which is now linked as the latest version on rust-lang.org,
despite link saying it's Rust 1.40.

Closes #500

Previously all December, November and October posts were buried
below February, because `2019/2/1` (Feb 1) is lexicographically
above (in front of?) `2019/10/1` (Oct 1). This is not how mother
nature intended it in ISO8601:

* https://en.wikipedia.org/wiki/ISO_8601

Let's correct this mistake by sorting dates with zero prefixed
month and day numbers to make all dates of fixed size.

Among other things, this puts Rust 1.40 (released `2019-12-19`)
as the version newer than Rust 1.38 (released `2019-09-26`),
which is now linked as the latest version on rust-lang.org,
despite link saying it's Rust 1.40.

Closes #500
@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Jan 26, 2020

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Mark-Simulacrum Mark-Simulacrum merged commit b65bdc5 into rust-lang:master Jan 26, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.