Core team membership changes #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
approved these changes
Oct 23, 2020
|
LGTM. |
| team: The Core Team <https://www.rust-lang.org/governance/teams/core> | ||
| --- | ||
|
|
||
| The core team has had a few membership updates in the last month, and we wanted to provide an update. |
There was a problem hiding this comment.
Suggested change
| The core team has had a few membership updates in the last month, and we wanted to provide an update. | |
| The core team has had a few membership updates in the last month and we wanted to provide an update. |
I can't tell if there should be a comma here or not :P whichever looks better to you
There was a problem hiding this comment.
Seems fine as is
There was a problem hiding this comment.
Accepted style is using commas in compound sentences, if we care about that .
I tend to use them when I actually want it to feel pause-y
Manishearth
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.