Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text indicates compiler errors but Ferris doesn't #1697

Open
codesections opened this issue Dec 18, 2018 · 4 comments
Labels

Comments

@codesections
Copy link

@codesections codesections commented Dec 18, 2018

In a few instances, the text of the book correctly notes that a provided code example will not compile. However, the corresponding code example lacks a Ferris with a question mark. For example, Ch17.3 notes that Listing 17-11 "won’t compile yet because we haven’t implemented the blog crate yet" but Listing 17-11 does not have a Ferris (or a red background). Would a PR noting these discrepancies be helpful (or, alternatively, have I misunderstood something and it is appropriate for these code samples to lack a confused Ferris)?

@steveklabnik

This comment has been minimized.

Copy link
Member

@steveklabnik steveklabnik commented Dec 18, 2018

I havne't triple checked the source, but if they aren't marked appropriately, they won't show the ferris. it's entirely possible that we just missed the marker somewhere; the ferris feature is pretty new!

@codesections

This comment has been minimized.

Copy link
Author

@codesections codesections commented Dec 18, 2018

Would e-help be appreciated on this, or is it something y'all will catch on a later pass? Happy to run though the code to spot those issues, but I don't want to be a pest if getting a PR would be a bother.

@steveklabnik

This comment has been minimized.

Copy link
Member

@steveklabnik steveklabnik commented Dec 18, 2018

I'd love a PR!

@u32i64

This comment has been minimized.

Copy link
Contributor

@u32i64 u32i64 commented Jan 4, 2019

In fact, there are similar problems in chapters 05, 12, and 20 as per #1505's 1st unresolved question. The appropriate code blocks were not annotated because of the resolution in #1505 (comment) by @steveklabnik, which was:

I think leaving it purely as the status at that point is the right call.

So it is questionable whether this needs to be done. In case the decision is to show Ferris on those as well, the appropriate code blocks can be marked; one can see the different attributes used for this by opening Screenshots in the #1505 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.