Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork the second edition into the 2018 edition #1297

Merged
merged 5 commits into from Apr 5, 2018
Merged

Conversation

steveklabnik
Copy link
Member

It's that time! We cannot yet modify chapters the introduction, chapters 1, 10, 18, 19, and 20, nor the appendices, But that's close enough to get going.

A few notes for you, Carol:

  1. check out the CONTRIBUTING changes; I'm basically declaring the first edition totally frozen, and cleaning up the info on the second edition to say "hey we can make some small changes but that's it" and dropping the other stuff.
  2. I tweaked the book index slightly. Accepting this PR doesn't mean that the 2018 edition is being published anywhere yet, so we don't yet mention it there. It's not totally clear when we'll want to; probably after we can modify all chapters.
  3. Given the contribution stance, I modified them in all three books to be the same. This means that the intro for second edition got tweaked slightly; let me know if you want me to revert that or if this is okay.
  4. the 2018 edition is currently 100% identical to the second edition with the exception of the source link. Actual work will start after we land all this.

we don't talk about 2018 yet, but eventually we will
Also update the GitHub links of first and second edition
I shouldn't have deleted these tools
@steveklabnik
Copy link
Member Author

We might want to refactor the tooling out so that we use one copy of the tool for both editions, but i feel like that isn't urgent and can be a follow-up

Copy link
Member

@carols10cents carols10cents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me! There are a few typos in some of the new contributing text, but those can be fixed later :)

@carols10cents carols10cents merged commit e7787f7 into master Apr 5, 2018
@carols10cents carols10cents deleted the 2018-edition branch April 5, 2018 21:04
steveklabnik added a commit that referenced this pull request May 21, 2018
In #1297, I forked the 2018 edition off. At the time, not all chapters were ready. The second edition has now shipped, and so these chapters are now updated with those last changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants