Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upBunch of improvements on explaining `impl Trait` #1481
+145
−17
Conversation
earthengine
added some commits
Aug 10, 2018
nekketsuuu
referenced this pull request
Aug 30, 2018
Closed
Chapter 10-2: wrong example for complex trait bounds #1504
phiresky
reviewed
Oct 18, 2018
2018-edition/src/ch10-02-traits.md Outdated
This comment has been minimized.
This comment has been minimized.
|
Hi, thank you for the PR! However, I think a lot of these are details that new Rust users don't need to know right away. The book is very much trying to give just what you need to know to be productive, and other resources like the Reference or the Nomicon or perhaps new resources are better places for the details you've added here. So thank you, but I'm going to close this. |
carols10cents
closed this
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
earthengine commentedAug 11, 2018
•
edited
The section 10-2 especially the
impl Traitpart is incorrect or at least misleading.This work is:
impl Traitmeans anonymous type, because many people believe it is just syntax sugar in argument position, and existential in return position. This is misunderstanding of this feature.impl Traiton the same trait means two different types)impl Traitin return position, with example codes of alternatives.