Update 2018 for module changes #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketsuban
reviewed
Sep 19, 2018
| and absolute paths. This way, when you move code around, the imports it needs | ||
| don't change. Up to you! | ||
|
|
||
| A breif note about idioms: |
ketsuban
reviewed
Sep 19, 2018
| use std::collections::*; | ||
| ``` | ||
|
|
||
| Be careful with this! This makes it a little harder to tell what names are in |
There was a problem hiding this comment.
Might be worth mentioning the "prelude" pattern here, since this is a common way to make glob imports useful.
hariharan-uno
reviewed
Sep 20, 2018
2018-edition/src/SUMMARY.md
Outdated
| - [`mod` and the Filesystem](ch07-01-mod-and-the-filesystem.md) | ||
| - [Controlling Visibility with `pub`](ch07-02-controlling-visibility-with-pub.md) | ||
| - [Referring to Names in Different Modules](ch07-03-importing-names-with-use.md) | ||
| - [Pacakges, Crates, and Modules](ch07-00-packages-crates-and-modules.md) |
There was a problem hiding this comment.
Yup! Did you read the text?
There was a problem hiding this comment.
I haven't read all of the text but found one more instance of the misspelling.
:%s/Pacakges/Packages/g
There was a problem hiding this comment.
Ah, I just misunderstood you. Thanks so much!
|
Oh, I didn’t realize you were talking about spelling! So sorry! I thought you weren’t sure what a package is.
I’ll update this, thank you!
… On Sep 20, 2018, at 3:09 PM, Hari haran ***@***.***> wrote:
@hariharan-uno commented on this pull request.
In 2018-edition/src/SUMMARY.md:
> @@ -36,10 +36,9 @@
## Basic Rust Literacy
-- [Modules](ch07-00-modules.md)
- - [`mod` and the Filesystem](ch07-01-mod-and-the-filesystem.md)
- - [Controlling Visibility with `pub`](ch07-02-controlling-visibility-with-pub.md)
- - [Referring to Names in Different Modules](ch07-03-importing-names-with-use.md)
+- [Pacakges, Crates, and Modules](ch07-00-packages-crates-and-modules.md)
I haven't read all of the text but found one more instance of the misspelling.
:%s/Pacakges/Packages/g
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
steveklabnik
force-pushed
the
update-for-modules
branch
from
6d9a4fe
to
68ac9b3
Compare
|
I'm going to merge this in for now; I'd like to do significant more work on it, but let's at least get the basics in. Carol, we'll review this more later :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #1280
Fixes #1509
r? @carols10cents
I feel like this is a bit rough.