Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Creates script that formats apostrophes/quotes nicely if outside of c… #380
…ode block, inline code or html tag; applies it to all markdown files in project.
This is my first Rust program ever, so hopefully it isn’t too much “spaghetti code”. If you can let me know how I can improve it, I will!
I applied it to all markdown files in the project with
This script considers that all
Nice work, this is looking great and will be really useful!!! I'm sorry that I've taken so long to get back to you!
I found one edge case, on this line in the diff: https://github.com/rust-lang/book/pull/380/files#diff-3050b578efb0fc3da82cb00232968d03L223
I would have expected the quotes within the inline code to be unchanged, but they have been changed. The strange thing is if I put that line in its own file, it doesn't change the quotes, as I expect. So I'm not sure what it is, but something about the content before then in chapter 1 is confusing
Do you mind taking a look into what's going on?
Thanks!!! I'm honored we're your first Rust code!!!
Hey @steveklabnik, sorry for dropping off the face of the earth. I've got a few other commitments I have to finish before getting back to this, but would likely be able to pick it back up in a few weeks. If anyone else is interested in looking into this before then that would be great! Otherwise I would be happy to pick it up again soon.