Creates script that formats apostrophes/quotes nicely if outside of c… #380

Open
wants to merge 2 commits into
from

Projects

None yet

3 participants

@lancelafontaine

…ode block, inline code or html tag; applies it to all markdown files in project.

This is my first Rust program ever, so hopefully it isn’t too much “spaghetti code”. If you can let me know how I can improve it, I will!

I applied it to all markdown files in the project with for f in ./**/*.md; do; cat "$f" | ./target/debug/quote2curly | tee "$f"; done;. I looked most of the output and it looks good to me.

This script considers that all " in html tags are within one line. The only outcome of this is that commented paragraphs also get parse and formatted.

@lancelafontaine lancelafontaine Creates script that formats apostrophes/quotes nicely if outside of c…
…ode block, inline code or html tag; applies it to all markdown files in project.
a296f20
@steveklabnik

one tiny thing 😄

tools/src/bin/quote2curly.rs
+ }
+ else {
+ let mut modified_line = &mut String::new();
+ let mut previous_char = '⌨'; // default non-alphanumeric char
@lancelafontaine
lancelafontaine Jan 1, 2017

Nice, I was looking for something along those lines and resulted to using an arbitrary character. Fixed in caf951f.

@carols10cents
Member

Nice work, this is looking great and will be really useful!!! I'm sorry that I've taken so long to get back to you!

I found one edge case, on this line in the diff: https://github.com/rust-lang/book/pull/380/files#diff-3050b578efb0fc3da82cb00232968d03L223

I would have expected the quotes within the inline code to be unchanged, but they have been changed. The strange thing is if I put that line in its own file, it doesn't change the quotes, as I expect. So I'm not sure what it is, but something about the content before then in chapter 1 is confusing is_in_inline_code? Also just after that are some missed quotes, but by line 243 it's replacing things properly again...

Do you mind taking a look into what's going on?

Thanks!!! I'm honored we're your first Rust code!!! ❤️

@lancelafontaine

Hmm, that is strange. I'll have time in a couple days to investigate (and fix the merge conflict). I'll post back soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment