Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish source tarballs of Cargo releases #2107

Closed
brson opened this Issue Nov 4, 2015 · 7 comments

Comments

Projects
None yet
6 participants
@brson
Copy link
Contributor

brson commented Nov 4, 2015

Although Cargo does have tagged releases, we don't publish source tarballs (the GitHub auto-tarballs are of course broken because submodules). Distros generally prefer tarballs to git.

Update the make dist rules to publish source tarballs consistently with Rust's own.

This will also likely require adding 'stable' dist bots for cargo.

re https://internals.rust-lang.org/t/perfecting-rust-packaging-the-plan/2767

@lucab

This comment has been minimized.

Copy link
Contributor

lucab commented Dec 13, 2015

Just for reference: as of today, Debian is using github auto-tarballs of cargo tags as tagged releases. The only git submodule in use is rust-installer, which at moment is probably useless for most of downstream distributors.

You may however still want to improve the status quo on your side, as the rust binary installer itself is not using/providing tagged cargo releases.

EDIT: s/stable releases/tagged releases/

@steveklabnik

This comment has been minimized.

Copy link
Member

steveklabnik commented Dec 13, 2015

as the rust binary installer itself is not using/providing stable cargo releases.

There are no 'stable' releases of Cargo at the moment, there are only nightlies. That doesn't mean that we're going to break the public interface, it's about the internals.

@lucab

This comment has been minimized.

Copy link
Contributor

lucab commented Dec 13, 2015

My bad, my comment was only meant to talk about release artifacts, not internals stability. I've updated it as I understand the term 'stable releases' was wrong and confusing.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Oct 3, 2016

Note that if we do this I think we'll want to take advantage of cargo-vendor to pre-download all deps ahead of time.

@cuviper

This comment has been minimized.

Copy link
Member

cuviper commented Oct 3, 2016

The cargo snapshot may have to be advanced for that. The current choice only supports the older registry-index style as generated by cargo-vendor 0.1.0. Newer versions make directory registries.

FWIW in Fedora I'm currently using the git tags to get a source archive from GitHub, along with a cargo-vendor tarball that I prepare myself.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Oct 3, 2016

Oh yeah to support literally cargo-vendor today we'd need to fast-forward the "stage0" of Cargo to a Cargo that supports it. We just released Cargo 0.13.0, though, which supports it, so it may be plausible to snap to that if we need.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jan 3, 2018

This is now transitively done through rust's source tarballs, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.