Join GitHub today
Add a flag to build profiles to enable overflow checking #2262
Would it be possible to add a flag to the build profiles:
That allows us to turn overflow checking on? (that is, enable
While we probably wouldn't ship Servo this way, being able to turn it on in our CI systems would catch a bunch of bugs without requiring us to spin up a parallel set of debug-only builders.
There's definitely an interesting question of this I think of where the configuration should go. For something like this it may make sense actually in a few locations. Profiles aren't always the best place because there's only one global compilation profile (chosen by the root crate), which overrides local configuration. So for a use case of "I want overflow checks always enabled in this crate" it's not quite appropriate, but for a CI system it may be appropriate.
That being said Cargo profiles aren't great for CI systems right now as it involves editing Cargo.toml where it's easier to just pass a CLI flag, so there's also that to consider.
Overall, though, I'm very wary about stabilizing any usage of
referenced this issue
Feb 24, 2016
Now that rust-lang/rust#33134 is stabilizing