Crate DAG is not respected when filling in -L flags #2354
Comments
alexcrichton
added a commit
to alexcrichton/cargo
that referenced
this issue
Feb 2, 2016
Cargo needs to ensure that if a build script prints a `-L` path that it's the first `-L` path passed to the compiler. That way the build script can be sure that any output it generated is the first to be considered by the compiler. Closes rust-lang#2354
bors
added a commit
that referenced
this issue
Feb 2, 2016
Cargo needs to ensure that if a build script prints a `-L` path that it's the first `-L` path passed to the compiler. That way the build script can be sure that any output it generated is the first to be considered by the compiler. Closes #2354
|
Awesome, thanks for jumping on this so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now when Cargo passes
-Lflags to the compiler from the output of build scripts, the crate DAG is not preserved. For example, if crate A links against pathpathA, crate B links againstpathB, and B depends on A. Cargo will compile B like:Instead it should pass
pathBfirst and in general use a topological ordering to ensure that more relevant paths come first.This was discovered by Servo where a native library was being picked up from /usr/lib even though it was properly compiled into the build directory. The /usr/lib version wouldn't link while the build directory one was the correct one to use.
The text was updated successfully, but these errors were encountered: