Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow `cargo.toml` #45
Comments
This comment has been minimized.
This comment has been minimized.
|
I'd say a standard is better than everyone doing as they want. |
This comment has been minimized.
This comment has been minimized.
thehydroimpulse
commented
Jun 24, 2014
|
Agreed. |
This comment has been minimized.
This comment has been minimized.
|
@tbu- normally, I'd agree with you, but we also have to consider case-insensitive filesystems. |
This comment has been minimized.
This comment has been minimized.
|
@steveklabnik Fair point. |
This comment has been minimized.
This comment has been minimized.
|
I have started looking into this. @steveklabnik Do we want to be case-insensitive for so we can support case-insensitive systems or do we simply want to allow Cargo.toml and cargo.toml ? |
This comment has been minimized.
This comment has been minimized.
|
I personally feel we should do what |
This comment has been minimized.
This comment has been minimized.
|
Capital letters group it together with other similar configuration files and avoids it from being interspersed with other files and directories. |
This comment has been minimized.
This comment has been minimized.
|
@wycats I know in Ruby I'm used to seing Gemfile, Rakefile and other files with a leading capital letter. There are many possible conventions. Another one is dot files with a prefixed dot followed by all lowercase letters. So I guess there's a lot of different styles. I would be partial to allowing cargo.toml but it wouldn't bother me either way as a Cargo user. Tell me guys if we should continue with this one or if we should close it and keep the current convention. If we go ahead I'll try and make a patch. |
This comment has been minimized.
This comment has been minimized.
|
You don't want a leading I'd rather stick with the current convention, for the reasons I described. We can revisit this if it causes real problems. |
wycats
closed this
Jun 24, 2014
This comment has been minimized.
This comment has been minimized.
What other configuration files? |
This comment has been minimized.
This comment has been minimized.
sinistersnare
commented
Jun 25, 2014
|
@bjz id imagine Rakefile, Makefile, Gemfile at least. Notice that none of these have file extensions, whereas Cargo.toml does. Id prefer Cargofile is more to 'convention' than @wycats's argument. Config files with file extensions such as 'setup.py', 'project.clj' and 'pom.xml' all start with lowercase. Cargo's approach seems to be actually _most_ against the current convention than anything I have seen so far. |
This comment has been minimized.
This comment has been minimized.
asb
commented
Jun 27, 2014
|
+1 for Cargofile or cargo.toml. Cargo.toml is a weird merging of two conventions. |
This comment has been minimized.
This comment has been minimized.
aroman
commented
Jul 5, 2014
|
Another +1 for the proposed compromise — |
This comment has been minimized.
This comment has been minimized.
SaberUK
commented
Jul 5, 2014
|
I agree with making it lower cased. In general, build system file names either match |
This comment has been minimized.
This comment has been minimized.
beatgammit
commented
Sep 4, 2014
@wycats - How so? In my projects, I have
I agree. I would prefer
I'm sure there are more examples for both sides, but I don't think there's an argument for saying I haven't used a case-insensitive filesystem for years, so I'm a bit out-of-the-loop in terms of conventions there, so I could be missing something important. |
This comment has been minimized.
This comment has been minimized.
mahkoh
commented
Sep 4, 2014
I don't care either way but this is only true with LC_COLLATE=C and not with en_US.UTF-8. |
This comment has been minimized.
This comment has been minimized.
|
Having a |
This comment has been minimized.
This comment has been minimized.
sinistersnare
commented
Sep 17, 2014
|
@wycats can you please comment on the discourse thread for this issue? there has been a lot of discussion in favor of |
This comment has been minimized.
This comment has been minimized.
|
I guess there isn't such a large discussion because this is mostly bikeshedding. (?) |
This comment has been minimized.
This comment has been minimized.
asb
commented
Sep 18, 2014
|
@tbu- it kind of is, but on the other hand Cargo seems to arbitrarily choose to eschew either of the standard naming conventions for this sort of file (either cargo.toml or Cargofile) as @beatgammit explains |
This comment has been minimized.
This comment has been minimized.
jestan
commented
Oct 7, 2014
|
+1 for cargo.toml or Cargofile. I just started using Cargo and felt strange about the build filename |
nodakai
referenced this issue
Nov 8, 2014
Closed
Update the FAQ page to answer the really most frequenctly asked question #21
This comment has been minimized.
This comment has been minimized.
|
@headcrab-in-my-room CMake. |
This comment has been minimized.
This comment has been minimized.
|
+1 for |
This comment has been minimized.
This comment has been minimized.
shawnscode
commented
Dec 31, 2014
|
+1 for |
This comment has been minimized.
This comment has been minimized.
skyne98
commented
Jan 12, 2019
|
+1 for |
steveklabnik commentedJun 24, 2014
From http://www.reddit.com/r/rust/comments/28xyrc/cargo_alpha_is_here/cifnlkg
Would be nice to be consistent with
make, and while I preferCargo.toml, apparently a bunch of people feel the other way.