Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve feature and optional dependencies for workspace as a whole #5210

Open
ishitatsuyuki opened this issue Mar 20, 2018 · 0 comments
Open

Resolve feature and optional dependencies for workspace as a whole #5210

ishitatsuyuki opened this issue Mar 20, 2018 · 0 comments

Comments

@ishitatsuyuki
Copy link
Contributor

@ishitatsuyuki ishitatsuyuki commented Mar 20, 2018

Currently, a dependency's feature set is determined by what package is getting built, without considering other packages in the workspace. This will likely cause a crate to be compiled more than once with different feature sets.

Instead, we should consider the full workspace when resolving features. We have a few choices:

  • Assuming all of the features are enabled when resolving/compiling dependencies
    This will minimize the possibility we will be building a crate twice, but this can be unwanted behavior sometimes.
  • Assuming default features for all crate in the workspace
    This will be less surprising though it doesn't cover all the feature combinations that are possible.

Note that specifying features in workspace doesn't work anyway ¯\_(ツ)_/¯: #5015

Related: #4463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.