Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize environment variables for build scripts #5282

Open
matklad opened this Issue Apr 3, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@matklad
Copy link
Member

matklad commented Apr 3, 2018

Build scripts have access to the parent environment, and this may cause problem because it's not obvious which env vars are actually used by the build script, which hurts reproducible builds.

Perhaps we should use some kind of a whitelist of envvars to pass to build scripts?

@matklad matklad added the Rust-2018 label Apr 3, 2018

@jsgf

This comment has been minimized.

@matklad

This comment has been minimized.

Copy link
Member Author

matklad commented Apr 9, 2018

Discussed during a meeting: this might be a nice idea in theory, but it really needs some significant design work, to make sure this feature is actually usable.

@kornelski

This comment has been minimized.

Copy link
Contributor

kornelski commented Apr 21, 2018

The "non-obvious" part doesn't have to be solved by blocking env vars, but can be solved by tracking which ones were used.

This is already almost a solved problem, but it's blocked on a showstopping bug: #4587

@matklad matklad removed the Rust-2018 label Jun 26, 2018

@dwijnand dwijnand changed the title Sanitize environemt variables for build scripts Sanitize environment variables for build scripts Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.