Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upcargo fix: Pass `--all-targets` by default #5739
Comments
killercup
added
the
Command-fix
label
Jul 17, 2018
killercup
referenced this issue
Jul 17, 2018
Closed
cargo fix: Print targets/features/cfg that will be fixed #5740
alexcrichton
added this to the Edition Preview 2 milestone
Jul 17, 2018
alexcrichton
assigned
killercup
Jul 17, 2018
This comment has been minimized.
This comment has been minimized.
|
Another disadvantage (from my perspective, unless I'm mistaken) is that it makes it irregular with, say, |
dwijnand
referenced this issue
Jul 27, 2018
Merged
cargo fix: Pass `--all-targets` to `cargo fix` by default #5814
alexcrichton
added a commit
to alexcrichton/cargo
that referenced
this issue
Jul 27, 2018
bors
added a commit
that referenced
this issue
Jul 30, 2018
bors
closed this
in
#5814
Jul 30, 2018
dwijnand
referenced this issue
Sep 5, 2018
Closed
`cargo fix` doesn't work for no_std binaries / targets #5978
dwijnand
referenced this issue
Nov 1, 2018
Closed
`cargo fix --edition` compiles dependencies for all platforms #6244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
killercup commentedJul 17, 2018
After hearing from a few people that they expected
cargo fixto fix their tests by default and discussing this on discord, we now want to pass--all-targetsby default.The main disadvantage of this is that it hides some of the actual complexity -- while you get a lot more fixed code, optional features and
#[cfg(…)]parts are still not covered.