Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upcargo fix: Print targets/features/cfg that will be fixed #5740
Comments
killercup
added
the
Command-fix
label
Jul 17, 2018
killercup
added this to the Edition RC 1 milestone
Aug 14, 2018
killercup
added
the
E-help-wanted
label
Aug 14, 2018
This comment has been minimized.
This comment has been minimized.
|
This might require changing/dealing with some cargo internals. There is this method: cargo/src/cargo/ops/cargo_compile.rs Lines 440 to 448 in 6a7672e as part of |
This comment has been minimized.
This comment has been minimized.
JoshBrudnak
commented
Aug 19, 2018
|
@killercup I would like to help out with this. Thanks. |
aturon
assigned
killercup
Aug 21, 2018
This comment has been minimized.
This comment has been minimized.
|
@JoshBrudnak this is assigned to me to remind me to check in on this. How's it going? :) |
This comment has been minimized.
This comment has been minimized.
JoshBrudnak
commented
Aug 21, 2018
|
I haven't had much time to work on it, but I'll be able to look into it later today. Thanks. |
dwijnand
referenced this issue
Aug 29, 2018
Closed
[WIP] cargo fix: Print targets/features/cfg that will be fixed #5947
This comment has been minimized.
This comment has been minimized.
JoshBrudnak
commented
Aug 29, 2018
|
I guess I won't be working on this since @dwijnand took it. |
This comment has been minimized.
This comment has been minimized.
|
There's an initial, starting implementation in #5947, but @alexcrichton is hoping to get a few more user reports to figure out what needs printing. See his comment. |
This comment has been minimized.
This comment has been minimized.
|
Move to close? |
This comment has been minimized.
This comment has been minimized.
|
Agreed yeah, we can always reopen if necessary! |
killercup commentedJul 17, 2018
•
edited
With #5739,
cargo fixlearnt to check all targets by default. Since this might be a source of confusion, it would be helpful to also print out which targets we are fixing.Running
cargo fixshould print out a line like this (right at the start):