Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upcargo fix: Remove `extern crate` when migrating to Rust 2018 #5829
Comments
This comment has been minimized.
This comment has been minimized.
|
Thanks for the report! Implementation-wise this will actually go into the compiler as we'll be tweaking the lint to do this, mind refiling the issue over there? |
This comment has been minimized.
This comment has been minimized.
johnthagen
referenced this issue
Jul 29, 2018
Closed
Remove `extern crate` when migrating to Rust 2018 #52829
This comment has been minimized.
This comment has been minimized.
|
Ok great, thanks! |
alexcrichton
closed this
Jul 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
johnthagen commentedJul 29, 2018
It's been mentioned/requested multiple times on the internals thread that
cargo fixshould remove theextern cratestatements when moving to Rust 2018.Motivation
One of the big draws of Rust 2018's module system is that all of the "redundant"
extern cratelines can finally be removed. It took some of the excitement away when I went through all of thecargo fixsteps and still saw them there. I think it will just be a better experience for users to see one of the tangible benefits of this change. As it is right now, they just see thecrate::in front of all of their local imports and they might not realize what a nice change the module system updates really are.After I manually removed the😄 , but let's give this to users on the first go around.
extern crate's I did get my satisfying result