Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note the build profile in output by default #1374

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@alexcrichton
Copy link
Member

alexcrichton commented Mar 3, 2015

This commit changes the "Compiling" message of cargo:

# old
Compiling foo v0.1.0

# new
Compiling (debug) foo v0.1.0

This change is aimed at preventing mistakenly thinking that cargo build
produces optimized binaries as well as providing a clear indication of whether
the build is a debug build or a release build.

Closes #1309

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Mar 3, 2015

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented Mar 3, 2015

@rust-highfive rust-highfive assigned wycats and unassigned huonw Mar 3, 2015

@kornelski

This comment has been minimized.

Copy link
Contributor

kornelski commented Mar 4, 2015

LGTM :)

Note the build profile in output by default
This commit changes the "Compiling" message of cargo:

    # old
    Compiling foo v0.1.0

    # new
    Compiling (debug) foo v0.1.0

This change is aimed at preventing mistakenly thinking that `cargo build`
produces optimized binaries as well as providing a clear indication of whether
the build is a debug build or a release build.

Closes #1309
@tanadeau

This comment has been minimized.

Copy link
Contributor

tanadeau commented Mar 4, 2015

Could the descriptions be debug/unoptimized and release/optimized instead of just debug and release?

@alexcrichton alexcrichton force-pushed the alexcrichton:issue-1309 branch from b9d4dc9 to 1a73203 Mar 4, 2015

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented Mar 4, 2015

Hm I don't want to add too much output and currently the names mirror the debug and release directories that the output is going into. I would personally lean towards a concise output and see where it takes us before adding yet more output indicating whether it is optimized or not.

@tanadeau

This comment has been minimized.

Copy link
Contributor

tanadeau commented Mar 4, 2015

@alexcrichton That makes sense. 👍

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Mar 6, 2015

I personally appreciate having a clear indication what is being compiled and in what mode.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 6, 2015

☔️ The latest upstream changes (presumably #1373) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented May 8, 2015

No consensus was reached here and it seems that the necessity for this is far less now that we have target/debug and target/release, so I'm going to close this so that we may pursue this at a later date if necessary.

@alexcrichton alexcrichton deleted the alexcrichton:issue-1309 branch May 8, 2015

@alexcrichton alexcrichton restored the alexcrichton:issue-1309 branch May 8, 2015

@alexcrichton alexcrichton deleted the alexcrichton:issue-1309 branch Jul 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.