Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upNote the build profile in output by default #1374
Conversation
rust-highfive
assigned
huonw
Mar 3, 2015
This comment has been minimized.
This comment has been minimized.
rust-highfive
commented
Mar 3, 2015
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
r? @wycats |
rust-highfive
assigned
wycats
and unassigned
huonw
Mar 3, 2015
This comment has been minimized.
This comment has been minimized.
|
LGTM :) |
This comment has been minimized.
This comment has been minimized.
|
Could the descriptions be |
alexcrichton
force-pushed the
alexcrichton:issue-1309
branch
from
b9d4dc9
to
1a73203
Mar 4, 2015
This comment has been minimized.
This comment has been minimized.
|
Hm I don't want to add too much output and currently the names mirror the |
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton That makes sense. |
This comment has been minimized.
This comment has been minimized.
|
I personally appreciate having a clear indication what is being compiled and in what mode. |
This comment has been minimized.
This comment has been minimized.
|
|
alexcrichton
referenced this pull request
Mar 21, 2015
Closed
Make rustc and cargo produce optimized binaries by default #967
This comment has been minimized.
This comment has been minimized.
|
No consensus was reached here and it seems that the necessity for this is far less now that we have |
alexcrichton commentedMar 3, 2015
This commit changes the "Compiling" message of cargo:
This change is aimed at preventing mistakenly thinking that
cargo buildproduces optimized binaries as well as providing a clear indication of whether
the build is a debug build or a release build.
Closes #1309