Include lints.rust.unexpected_cfgs.check-cfg in the fingerprint#13958
Merged
bors merged 2 commits intorust-lang:masterfrom May 28, 2024
Merged
Include lints.rust.unexpected_cfgs.check-cfg in the fingerprint#13958bors merged 2 commits intorust-lang:masterfrom
lints.rust.unexpected_cfgs.check-cfg in the fingerprint#13958bors merged 2 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
When changing the
--check-cfgargs in thelints.rust.unexpected_cfgs.check-cfglint config, the build should be restarted as the arguments we pass to the compiler change, and they can change the diagnostics output by generating new or removing someunexpected_cfgswarning(s).How should we test and review this PR?
Look at the before and after test (separate commit).
Additional information
Similar to #13012 which did that for the declared features.
Contrary to that PR, I didn't add a new
DirtyReasonvariant, since even the[lints]table didn't get one.r? @epage