Skip to content

/cargo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing the non-root package #1705

Merged
merged 1 commit into from Jun 12, 2015

Conversation

Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@alexcrichton @rust-highfive @brson @bors @huonw
@alexcrichton
Copy link
Member

alexcrichton commented Jun 11, 2015

The previous overhaul of how dependencies among build dependencies were
traversed ended up picking the wrong root package when the -p argument was
specified to commands. This commit fixes this up by making sure the right root
package is passed along.
@alexcrichton
Fix testing the non-root package 
The previous overhaul of how dependencies among build dependencies were
traversed ended up picking the wrong root package when the `-p` argument was
specified to commands. This commit fixes this up by making sure the right root
package is passed along.
Loading status checks…
b3e2ac0

@rust-highfive rust-highfive assigned huonw Jun 11, 2015

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link

rust-highfive commented Jun 11, 2015

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jun 11, 2015

r? @brson

cc @metajack, this is the issue Servo was running into (tested locally to verify this fixes it)

@rust-highfive rust-highfive assigned brson and unassigned huonw Jun 11, 2015

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jun 12, 2015

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 12, 2015

📌 Commit b3e2ac0 has been approved by brson
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 12, 2015

⌛️ Testing commit b3e2ac0 with merge ae8b752...

bors added a commit that referenced this pull request Jun 12, 2015

@bors
Auto merge of #1705 - alexcrichton:fix-test-non-root-package, r=brson 
The previous overhaul of how dependencies among build dependencies were
traversed ended up picking the wrong root package when the `-p` argument was
specified to commands. This commit fixes this up by making sure the right root
package is passed along.
Loading status checks…
ae8b752
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 12, 2015

☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64

@bors bors merged commit b3e2ac0 into rust-lang:master Jun 12, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:fix-test-non-root-package branch Jun 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.