Quiet mode for all cargo commands

[pwoolcoc]

New version of #738, adds -q and --quiet to all cargo subcommands.

cc @sinistersnare (sorry it took me 1.5 months to circle back around to this)

[rust-highfive]

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

[huonw]

r? @alexcrichton

[sinistersnare]

Great! :) I have been busy with an internship for a bit so I have forgotten about this. Thanks for CCing me!

I wonder if panicking is the correct thing to do when both --quiet and --verbose are specified. Should we just default to one if both are specified?

[pwoolcoc]

Maybe it should default to Normal if both are passed? That is, passing both is the same as passing neither?

[pwoolcoc]

(also, it seems like Travis is complaining because rustup is broken on osx?)

[alexcrichton]

Cargo in general tries to not panic as much as possible, can this function return a CargoResult which is then handled through the normal means?

[alexcrichton]

Thanks! The travis failure looks benign, but can you also add some tests for this as well?

cc @wycats

[pwoolcoc]

r? @alexcrichton

[sinistersnare]

(Im not a reviewer, but) it looks good, thanks :)

[alexcrichton]

One-off errors like this can typically be created with human("cannot set both --verbose and --quiet")

[alexcrichton]

This would be a little more concise and exhaustive as:

self.verbosity = match (verbose, quiet) {
    (true, true) => return Err(human("...")),
    (true, false) => Verbose,
    (false, true) => Quiet,
    (false, false) => Normal,
};

[alexcrichton]

Can you add tests for:

• Running a cargo command with -q
• Running a cargo command with -q and -s.

Ah, also cc @rust-lang/tools

[pwoolcoc]

@alexcrichton pushed changes, thanks for the suggestions.

[alexcrichton]

Thanks! Could you also squash the commits together? Other than that I think this is good to go.

[pwoolcoc]

What? You don't want to merge 15 commits? :)

Will push the squashed commit momentarily.

[alexcrichton]

@bors: r+ 88e557f

Thanks!

[bors]

⌛️ Testing commit 88e557f with merge b48cd46...

[bors]

☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-64