Skip to content

/cargo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get `make test` working on MSVC #1757

Merged
merged 1 commit into from Jun 26, 2015

Conversation

Reviewers
No reviews
Assignees

@huonw huonw

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@alexcrichton @rust-highfive @huonw @bors @wycats @brson
@alexcrichton
Copy link
Member

alexcrichton commented Jun 26, 2015

This commit updates Cargo's unit tests to pass make check entirely on MSVC
targets. Two tests are ignored on MSVC as it requires panicking to be
implemented, which currently isn't, but otherwise Cargo is fully functional.
@alexcrichton
Get `make test` working on MSVC 
This commit updates Cargo's unit tests to pass `make check` entirely on MSVC
targets. Two tests are ignored on MSVC as it requires panicking to be
implemented, which currently isn't, but otherwise Cargo is fully functional.
Loading status checks…
f97579a

@rust-highfive rust-highfive assigned wycats Jun 26, 2015

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link

rust-highfive commented Jun 26, 2015

r? @wycats

(rust_highfive has picked a reviewer for you, use r? to override)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jun 26, 2015

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned wycats Jun 26, 2015

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jun 26, 2015

r? @huonw

@rust-highfive rust-highfive assigned huonw and unassigned brson Jun 26, 2015

@huonw

This comment has been minimized.

Sign in to view
Copy link
Member

huonw commented Jun 26, 2015

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 26, 2015

📌 Commit f97579a has been approved by huonw
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 26, 2015

⌛️ Testing commit f97579a with merge c8c1624...

bors added a commit that referenced this pull request Jun 26, 2015

@bors
Auto merge of #1757 - alexcrichton:fix-msvc-build, r=huonw 
This commit updates Cargo's unit tests to pass `make check` entirely on MSVC
targets. Two tests are ignored on MSVC as it requires panicking to be
implemented, which currently isn't, but otherwise Cargo is fully functional.
Loading status checks…
c8c1624
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 26, 2015

☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64

@bors bors merged commit f97579a into rust-lang:master Jun 26, 2015
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:fix-msvc-build branch Jul 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.