Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a custom trace! macro in resolution #1887

Merged
merged 1 commit into from Aug 11, 2015

Conversation

Projects
None yet
4 participants
@alexcrichton
Copy link
Member

alexcrichton commented Aug 11, 2015

Apparently not actually emitting the calls to trace! saves a good deal of stack
space, fixing the overflow found in #1875.

Closes #1875

Use a custom trace! macro in resolution
Apparently not actually emitting the calls to trace! saves a good deal of stack
space, fixing the overflow found in #1875.

Closes #1875
@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Aug 11, 2015

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@huonw

This comment has been minimized.

Copy link
Member

huonw commented Aug 11, 2015

@bors r+

This seems somewhat unfortunate, but I guess it makes sense.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 11, 2015

📌 Commit 0f3caf9 has been approved by huonw

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 11, 2015

⌛️ Testing commit 0f3caf9 with merge e943040...

bors added a commit that referenced this pull request Aug 11, 2015

Auto merge of #1887 - alexcrichton:smaller-stacks, r=huonw
Apparently not actually emitting the calls to trace! saves a good deal of stack
space, fixing the overflow found in #1875.

Closes #1875
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 11, 2015

💔 Test failed - cargo-win-gnu-64

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented Aug 11, 2015

@bors: retry

On Mon, Aug 10, 2015 at 5:29 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - cargo-win-gnu-64
http://buildbot.rust-lang.org/builders/cargo-win-gnu-64/builds/119


Reply to this email directly or view it on GitHub
#1887 (comment).

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 11, 2015

⚡️ Previous build results for cargo-linux-64, cargo-win-msvc-64 are reusable. Rebuilding only cargo-linux-32, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32...

@bors

This comment has been minimized.

@bors bors merged commit 0f3caf9 into rust-lang:master Aug 11, 2015

1 of 3 checks passed

continuous-integration/appveyor AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:smaller-stacks branch Aug 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.