Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upEven more manifest path consistency #1955
Conversation
rust-highfive
assigned
huonw
Aug 30, 2015
This comment has been minimized.
This comment has been minimized.
rust-highfive
commented
Aug 30, 2015
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
reviewed
Aug 31, 2015
src/bin/verify_project.rs
Outdated
| } | ||
| if !fs::metadata(&filename).is_ok() { | ||
| fail("invalid", &format!("manifest path `{}` does not exist", filename)) | ||
| } |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Looks great to me, thanks @carols10cents! Commands like this (and especially |
alexcrichton
assigned
alexcrichton
and unassigned
huonw
Aug 31, 2015
alexcrichton
referenced this pull request
Aug 31, 2015
Closed
locate-project usage message is wrong and option name non descriptive #1958
carols10cents
added some commits
Aug 29, 2015
carols10cents
force-pushed the
carols10cents:even-more-manifest-path-consistency
branch
from
4c12d39
to
ead966b
Sep 1, 2015
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton fixed!! Thank you!! |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Sep 1, 2015
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit ead966b
into
rust-lang:master
Sep 1, 2015
carols10cents
deleted the
carols10cents:even-more-manifest-path-consistency
branch
Sep 1, 2015
huonw
added a commit
to huonw/travis-cargo
that referenced
this pull request
Sep 2, 2015
carols10cents
referenced this pull request
Sep 3, 2015
Closed
--manifest-path provides poor diagnostics #1772
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
carols10cents commentedAug 30, 2015
Hiii :) This builds on #1953, so if yinz like this better, I'll close that one.
This PR makes all commands that take
--manifest-path(except locate-project, see below) behave in a consistent way with regards to invalid paths, and hopefully gives better error messages.This DOES break some instances where commands were "working", ie, completing their command successfully, with some path that they decided was right, not necessarily exactly the path that was passed in though. I'm not sure how this impacts whatever backwards compatibility guarantees cargo has. Given that those cases weren't using a valid path to an existing Cargo.toml, hopefully no one is relying on that behavior?
So locate-project... I'm not sure what to do about that one, exactly... If we define
--manifest-pathas a path to a Cargo.toml, then uhhhh we've located the project, it's right where you told us it is ;) So I think we should change it to be--search-pathor similar? I'm too sleepy to take care of that tonight, so I just left it out of the manifest path tests.