Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd limit parameter to search command (fix issue #2402) #2439
Conversation
rust-highfive
assigned
wycats
Mar 4, 2016
This comment has been minimized.
This comment has been minimized.
|
This have a problem with a limit greater that 100 (this limit is in the crates.io API). Here I can do 3 things, allow only limits values between 1 to 100, allow any value and let it crash when value is greater than 100, or query as pages as needed for satisfy the limit. Any suggestion? |
jespino
force-pushed the
jespino:issue-2402
branch
from
b6406b9
to
6840406
Mar 4, 2016
This comment has been minimized.
This comment has been minimized.
|
This looks good to me, I'm fine letting the maximum limit get defined by crates.io so we don't hardcode it in two places. |
alexcrichton
assigned
alexcrichton
and unassigned
wycats
Mar 4, 2016
This comment has been minimized.
This comment has been minimized.
|
Looks like a test may need to get updated as well? |
This comment has been minimized.
This comment has been minimized.
|
The crates.io maximum is about API results pagination, I think isn't directly related with the maximum on cargo search command, but I think 100 results is enough for the command line interface. I will allow only values 1..100. |
jespino
force-pushed the
jespino:issue-2402
branch
from
6840406
to
4fefe73
Mar 5, 2016
This comment has been minimized.
This comment has been minimized.
|
Looks like the tests may still be failing? |
jespino
force-pushed the
jespino:issue-2402
branch
from
4fefe73
to
53c9374
Mar 6, 2016
This comment has been minimized.
This comment has been minimized.
|
Now tests are fixed, I think the problem is a temporary problem obtaining a package. |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Mar 6, 2016
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
jespino commentedMar 4, 2016
No description provided.