New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban keywords from crate names #2707

Merged
merged 1 commit into from May 17, 2016

Conversation

Projects
None yet
5 participants
@sbeckeriv
Contributor

sbeckeriv commented May 17, 2016

Dearest Reviewer,

This pull request extends the banned list of project names to include
all of the current keywords for rust. I got the list of keywords from
https://doc.rust-lang.org/grammar.html#keywords . This
closes #2699 . The original ticket said warn but I figured how test is
handled is most likely how all banned names should be handled.

Oddly enough a few keywords have made their way to the crates.io. fn and
proc are both examples I found spot checking keywords. I do not there is
any action to take on those crates.

Thanks
Becker

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive May 17, 2016

r? @wycats

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive commented May 17, 2016

r? @wycats

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton May 17, 2016

Member

Thanks! Could you add a comment with a link to that page as well? Other than that r=me

Member

alexcrichton commented May 17, 2016

Thanks! Could you add a comment with a link to that page as well? Other than that r=me

Ban keywords from crate names
Dearest Reviewer,

This pull request extends the banned list of project names to include
all of the current keywords for rust. I got the list of keywords from
https://doc.rust-lang.org/grammar.html#keywords . This
closes #2699 . The original ticket said warn but I figured how test is
handled is most likely how all banned names should be handled.

Oddly enough a few keywords have made their way to the crates.io. fn and
proc are both examples I found spot checking keywords. I do not there is
any action to take on those crates.

Thanks
Becker
@sbeckeriv

This comment has been minimized.

Show comment
Hide comment
@sbeckeriv

sbeckeriv May 17, 2016

Contributor

Updated. Thanks!

Contributor

sbeckeriv commented May 17, 2016

Updated. Thanks!

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented May 17, 2016

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors May 17, 2016

Contributor

⌛️ Testing commit 466c74a with merge 42bce5c...

Contributor

bors commented May 17, 2016

⌛️ Testing commit 466c74a with merge 42bce5c...

bors added a commit that referenced this pull request May 17, 2016

Auto merge of #2707 - sbeckeriv:banned-list-2699, r=alexcrichton
Ban keywords from crate names

Dearest Reviewer,

This pull request extends the banned list of project names to include
all of the current keywords for rust. I got the list of keywords from
https://doc.rust-lang.org/grammar.html#keywords . This
closes #2699 . The original ticket said warn but I figured how test is
handled is most likely how all banned names should be handled.

Oddly enough a few keywords have made their way to the crates.io. fn and
proc are both examples I found spot checking keywords. I do not there is
any action to take on those crates.

Thanks
Becker

@bors bors merged commit 466c74a into rust-lang:master May 17, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@sbeckeriv sbeckeriv deleted the sbeckeriv:banned-list-2699 branch Jul 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment