New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RUSTDOCFLAGS #2794

Merged
merged 1 commit into from Jul 6, 2016

Conversation

Projects
None yet
5 participants
@alexcrichton
Member

alexcrichton commented Jun 20, 2016

Like with RUSTFLAGS, parse this variable to pass along extra arguments to
invocations of rustdoc.

Add support for RUSTDOCFLAGS
Like with RUSTFLAGS, parse this variable to pass along extra arguments to
invocations of `rustdoc`.
@rust-highfive

This comment has been minimized.

rust-highfive commented Jun 20, 2016

r? @wycats

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Jun 20, 2016

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned wycats Jun 20, 2016

@brson

This comment has been minimized.

Contributor

brson commented Jun 21, 2016

Hm, rustdoc's interface is much less scrutinized than rustcs. When I look at it it's mostly a bunch of stuff I don't want people to touch (apparently rustdoc can load plugins...).

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Jun 21, 2016

Yeah it's true that most things I wouldn't want to expose, but the motivation here is twofold for me at least:

  • Provide any means possible to pass options like --markdown-css and --html-in-header, alleviating pressure on PRs like #2664
  • Adding consistency with RUSTFLAGS and how to pass custom args to the underlying tool.

Ideally we'd provide configuration in Cargo.toml for various properties, but we unfortunately haven't figured out a story for passing through arguments to rustc/rustdoc like that yet.

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Jul 5, 2016

@brson, thoughts on how this is consistent with RUSTFLAGS?

@brson

This comment has been minimized.

Contributor

brson commented Jul 6, 2016

@bors r+

I suppose I don't care enough to argue against it.

@bors

This comment has been minimized.

Contributor

bors commented Jul 6, 2016

📌 Commit f639d38 has been approved by brson

@bors

This comment has been minimized.

Contributor

bors commented Jul 6, 2016

⌛️ Testing commit f639d38 with merge 270200b...

bors added a commit that referenced this pull request Jul 6, 2016

Auto merge of #2794 - alexcrichton:rustdocflags, r=brson
Add support for RUSTDOCFLAGS

Like with RUSTFLAGS, parse this variable to pass along extra arguments to
invocations of `rustdoc`.
@bors

This comment has been minimized.

Contributor

bors commented Jul 6, 2016

@bors bors merged commit f639d38 into rust-lang:master Jul 6, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:rustdocflags branch Jul 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment