Skip to content

/cargo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote duplicate build target error to a warning #2962

Merged
merged 1 commit into from Aug 5, 2016

Conversation

Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@alexcrichton @rust-highfive @brson @bors @coder543
@alexcrichton
Copy link
Member

alexcrichton commented Aug 5, 2016

Added in #2847 this ended up unfortunately breaking the regex crate on
nightly, so let's just issue a warning for awhile first. Eventually we can
promote this to an error if it becomes a problem.
@alexcrichton
Demote duplicate build target error to a warning 
Added in #2847 this ended up unfortunately breaking the `regex` crate on
nightly, so let's just issue a warning for awhile first. Eventually we can
promote this to an error if it becomes a problem.
Loading status checks…
c261964
@rust-highfive

This comment has been minimized.

Sign in to view
Copy link

rust-highfive commented Aug 5, 2016

@alexcrichton: no appropriate reviewer found, use r? to override
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Aug 5, 2016

r? @brson

@rust-highfive rust-highfive assigned brson Aug 5, 2016

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Aug 5, 2016

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 5, 2016

📌 Commit c261964 has been approved by brson
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 5, 2016

⌛️ Testing commit c261964 with merge 4e66190...

bors added a commit that referenced this pull request Aug 5, 2016

@bors
Auto merge of #2962 - alexcrichton:demote-error, r=brson 
Demote duplicate build target error to a warning

Added in #2847 this ended up unfortunately breaking the `regex` crate on
nightly, so let's just issue a warning for awhile first. Eventually we can
promote this to an error if it becomes a problem.
Loading status checks…
4e66190
@coder543

This comment has been minimized.

Sign in to view
Copy link

coder543 commented Aug 5, 2016 •
edited

Just ran into this issue, glad to see it getting fixed so quickly.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Aug 5, 2016

I've also made a post on internals with a heads up about this issue.
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 5, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: brson
Pushing 4e66190 to master...

@bors bors merged commit c261964 into rust-lang:master Aug 5, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@steveklabnik steveklabnik referenced this pull request Aug 5, 2016

Closed

Nightly fails to compile the latest regex crate #2963

@alexcrichton alexcrichton deleted the alexcrichton:demote-error branch Aug 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.