New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore `panic` configuration for test/bench profiles #3175

Merged
merged 1 commit into from Nov 3, 2016

Conversation

Projects
None yet
5 participants
@alexcrichton
Copy link
Member

alexcrichton commented Oct 7, 2016

Both of these profiles link to libtest, so it's invalid to configure them with
panic="abort". To prevent confusing errors just ignore the configuration for
now.

Closes #3166

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Oct 7, 2016

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Oct 17, 2016

ping r? @brson

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 2, 2016

☔️ The latest upstream changes (presumably #3242) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the alexcrichton:bench-abort branch from 3e81fde to 4a73741 Nov 2, 2016

Ignore `panic` configuration for test/bench profiles
Both of these profiles link to libtest, so it's invalid to configure them with
`panic="abort"`. To prevent confusing errors just ignore the configuration for
now.

Closes #3166

@alexcrichton alexcrichton force-pushed the alexcrichton:bench-abort branch from 4a73741 to 0f44202 Nov 2, 2016

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Nov 3, 2016

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 3, 2016

📌 Commit 0f44202 has been approved by brson

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 3, 2016

⌛️ Testing commit 0f44202 with merge cb524b7...

bors added a commit that referenced this pull request Nov 3, 2016

Auto merge of #3175 - alexcrichton:bench-abort, r=brson
Ignore `panic` configuration for test/bench profiles

Both of these profiles link to libtest, so it's invalid to configure them with
`panic="abort"`. To prevent confusing errors just ignore the configuration for
now.

Closes #3166
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 3, 2016

@bors bors merged commit 0f44202 into rust-lang:master Nov 3, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:bench-abort branch Nov 3, 2016

@alecmocatta

This comment has been minimized.

Copy link

alecmocatta commented Oct 19, 2018

@alexcrichton In light of harness = false, does a blanket ignore of panic = "abort" for test/bench profiles still make sense?

I just tried this and was surprised to get `panic` setting is ignored for `test` profile, given that the integration test I wanted to run doesn't link to libtest.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Oct 20, 2018

@alecmocatta this PR is nearly two years old and is, uh, very far out of cache. Perhaps a new issue could be opened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment