Compile statically against the MSVC CRT #3363

Merged
merged 1 commit into from Dec 14, 2016

Projects

None yet

4 participants

@alexcrichton
Member

This updates our AppVeyor builds to compile with -Ctarget-feature=+crt-static
to help Cargo be a bit more portable and not rely on the MSVC redistributable
artifacts. Over time this may even let us converge on only releasing one build
of Cargo and just pairing that with all Windows toolchains...

@brson brson was assigned by rust-highfive Dec 2, 2016
@rust-highfive

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Contributor
bors commented Dec 13, 2016

โ˜”๏ธ The latest upstream changes (presumably #3395) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton Compile statically against the MSVC CRT
This updates our AppVeyor builds to compile with `-Ctarget-feature=+crt-static`
to help Cargo be a bit more portable and not rely on the MSVC redistributable
artifacts. Over time this may even let us converge on only releasing one build
of Cargo and just pairing that with all Windows toolchains...
db60e6c
@alexcrichton
Member

@bors: r+

@bors
Contributor
bors commented Dec 13, 2016

๐Ÿ“Œ Commit db60e6c has been approved by alexcrichton

@bors
Contributor
bors commented Dec 13, 2016

โŒ›๏ธ Testing commit db60e6c with merge ff5ae77...

@bors bors added a commit that referenced this pull request Dec 13, 2016
@bors bors Auto merge of #3363 - alexcrichton:libcmt, r=alexcrichton
Compile statically against the MSVC CRT

This updates our AppVeyor builds to compile with `-Ctarget-feature=+crt-static`
to help Cargo be a bit more portable and not rely on the MSVC redistributable
artifacts. Over time this may even let us converge on only releasing one build
of Cargo and just pairing that with all Windows toolchains...
ff5ae77
@bors
Contributor
bors commented Dec 13, 2016

๐Ÿ’” Test failed - status-appveyor

@alexcrichton
Member
@bors
Contributor
bors commented Dec 14, 2016

โŒ›๏ธ Testing commit db60e6c with merge ffa8b6e...

@bors bors added a commit that referenced this pull request Dec 14, 2016
@bors bors Auto merge of #3363 - alexcrichton:libcmt, r=alexcrichton
Compile statically against the MSVC CRT

This updates our AppVeyor builds to compile with `-Ctarget-feature=+crt-static`
to help Cargo be a bit more portable and not rely on the MSVC redistributable
artifacts. Over time this may even let us converge on only releasing one build
of Cargo and just pairing that with all Windows toolchains...
ffa8b6e
@bors
Contributor
bors commented Dec 14, 2016

โ˜€๏ธ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing ffa8b6e to master...

@bors bors merged commit db60e6c into rust-lang:master Dec 14, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors bors referenced this pull request Dec 14, 2016
Merged

Bump libz-sys to 1.0.9 #3393

@alexcrichton alexcrichton deleted the alexcrichton:libcmt branch Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment