Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile statically against the MSVC CRT #3363

Merged
merged 1 commit into from Dec 14, 2016
Merged

Conversation

@alexcrichton
Copy link
Member

alexcrichton commented Dec 2, 2016

This updates our AppVeyor builds to compile with -Ctarget-feature=+crt-static
to help Cargo be a bit more portable and not rely on the MSVC redistributable
artifacts. Over time this may even let us converge on only releasing one build
of Cargo and just pairing that with all Windows toolchains...

@rust-highfive
Copy link

rust-highfive commented Dec 2, 2016

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton force-pushed the alexcrichton:libcmt branch 2 times, most recently from 4b936aa to 3392ae2 Dec 13, 2016
@bors
Copy link
Contributor

bors commented Dec 13, 2016

The latest upstream changes (presumably #3395) made this pull request unmergeable. Please resolve the merge conflicts.

This updates our AppVeyor builds to compile with `-Ctarget-feature=+crt-static`
to help Cargo be a bit more portable and not rely on the MSVC redistributable
artifacts. Over time this may even let us converge on only releasing one build
of Cargo and just pairing that with all Windows toolchains...
@alexcrichton alexcrichton force-pushed the alexcrichton:libcmt branch from 3392ae2 to db60e6c Dec 13, 2016
@alexcrichton
Copy link
Member Author

alexcrichton commented Dec 13, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 13, 2016

📌 Commit db60e6c has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Dec 13, 2016

Testing commit db60e6c with merge ff5ae77...

bors added a commit that referenced this pull request Dec 13, 2016
Compile statically against the MSVC CRT

This updates our AppVeyor builds to compile with `-Ctarget-feature=+crt-static`
to help Cargo be a bit more portable and not rely on the MSVC redistributable
artifacts. Over time this may even let us converge on only releasing one build
of Cargo and just pairing that with all Windows toolchains...
@bors
Copy link
Contributor

bors commented Dec 13, 2016

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member Author

alexcrichton commented Dec 14, 2016

@bors
Copy link
Contributor

bors commented Dec 14, 2016

Testing commit db60e6c with merge ffa8b6e...

bors added a commit that referenced this pull request Dec 14, 2016
Compile statically against the MSVC CRT

This updates our AppVeyor builds to compile with `-Ctarget-feature=+crt-static`
to help Cargo be a bit more portable and not rely on the MSVC redistributable
artifacts. Over time this may even let us converge on only releasing one build
of Cargo and just pairing that with all Windows toolchains...
@bors
Copy link
Contributor

bors commented Dec 14, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing ffa8b6e to master...

@bors bors merged commit db60e6c into rust-lang:master Dec 14, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors bors mentioned this pull request Dec 14, 2016
@alexcrichton alexcrichton deleted the alexcrichton:libcmt branch Dec 14, 2016
@pravic
Copy link

pravic commented Jun 20, 2017

Is there a way to specify a crt-static feature in Cargo.toml? Besides .cargo/config, which requires nightly in addition.

@alexcrichton
Copy link
Member Author

alexcrichton commented Jun 20, 2017

Not currently, no. It needs to be specified as part of RUSTFLAGS currently

@pravic
Copy link

pravic commented Jun 20, 2017

I see. Thanks anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.