New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile statically against the MSVC CRT #3363

Merged
merged 1 commit into from Dec 14, 2016

Conversation

Projects
None yet
5 participants
@alexcrichton
Member

alexcrichton commented Dec 2, 2016

This updates our AppVeyor builds to compile with -Ctarget-feature=+crt-static
to help Cargo be a bit more portable and not rely on the MSVC redistributable
artifacts. Over time this may even let us converge on only releasing one build
of Cargo and just pairing that with all Windows toolchains...

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Dec 2, 2016

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive commented Dec 2, 2016

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 13, 2016

Contributor

☔️ The latest upstream changes (presumably #3395) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

bors commented Dec 13, 2016

☔️ The latest upstream changes (presumably #3395) made this pull request unmergeable. Please resolve the merge conflicts.

Compile statically against the MSVC CRT
This updates our AppVeyor builds to compile with `-Ctarget-feature=+crt-static`
to help Cargo be a bit more portable and not rely on the MSVC redistributable
artifacts. Over time this may even let us converge on only releasing one build
of Cargo and just pairing that with all Windows toolchains...
@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented Dec 13, 2016

@bors: r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 13, 2016

Contributor

📌 Commit db60e6c has been approved by alexcrichton

Contributor

bors commented Dec 13, 2016

📌 Commit db60e6c has been approved by alexcrichton

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 13, 2016

Contributor

⌛️ Testing commit db60e6c with merge ff5ae77...

Contributor

bors commented Dec 13, 2016

⌛️ Testing commit db60e6c with merge ff5ae77...

bors added a commit that referenced this pull request Dec 13, 2016

Auto merge of #3363 - alexcrichton:libcmt, r=alexcrichton
Compile statically against the MSVC CRT

This updates our AppVeyor builds to compile with `-Ctarget-feature=+crt-static`
to help Cargo be a bit more portable and not rely on the MSVC redistributable
artifacts. Over time this may even let us converge on only releasing one build
of Cargo and just pairing that with all Windows toolchains...
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 13, 2016

Contributor

💔 Test failed - status-appveyor

Contributor

bors commented Dec 13, 2016

💔 Test failed - status-appveyor

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Dec 14, 2016

Member
Member

alexcrichton commented Dec 14, 2016

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 14, 2016

Contributor

⌛️ Testing commit db60e6c with merge ffa8b6e...

Contributor

bors commented Dec 14, 2016

⌛️ Testing commit db60e6c with merge ffa8b6e...

bors added a commit that referenced this pull request Dec 14, 2016

Auto merge of #3363 - alexcrichton:libcmt, r=alexcrichton
Compile statically against the MSVC CRT

This updates our AppVeyor builds to compile with `-Ctarget-feature=+crt-static`
to help Cargo be a bit more portable and not rely on the MSVC redistributable
artifacts. Over time this may even let us converge on only releasing one build
of Cargo and just pairing that with all Windows toolchains...
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 14, 2016

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing ffa8b6e to master...

Contributor

bors commented Dec 14, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing ffa8b6e to master...

@bors bors merged commit db60e6c into rust-lang:master Dec 14, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@bors bors referenced this pull request Dec 14, 2016

Merged

Bump libz-sys to 1.0.9 #3393

@alexcrichton alexcrichton deleted the alexcrichton:libcmt branch Dec 14, 2016

@pravic

This comment has been minimized.

Show comment
Hide comment
@pravic

pravic Jun 20, 2017

Is there a way to specify a crt-static feature in Cargo.toml? Besides .cargo/config, which requires nightly in addition.

pravic commented Jun 20, 2017

Is there a way to specify a crt-static feature in Cargo.toml? Besides .cargo/config, which requires nightly in addition.

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Jun 20, 2017

Member

Not currently, no. It needs to be specified as part of RUSTFLAGS currently

Member

alexcrichton commented Jun 20, 2017

Not currently, no. It needs to be specified as part of RUSTFLAGS currently

@pravic

This comment has been minimized.

Show comment
Hide comment
@pravic

pravic Jun 20, 2017

I see. Thanks anyway

pravic commented Jun 20, 2017

I see. Thanks anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment