New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android build support #3885

Merged
merged 4 commits into from Apr 12, 2017

Conversation

Projects
None yet
4 participants
@malbarbo
Copy link
Contributor

malbarbo commented Mar 30, 2017

This add android build support, including openssl.

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Mar 30, 2017

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@malbarbo

This comment has been minimized.

Copy link
Contributor

malbarbo commented Mar 30, 2017

There is some interest on using rust on android (termux/termux-packages#261). rustup already has android build support.

Even if cargo is being build with rust, I think it is good to have a docker image to build cargo.

What about the travis android build? Should I remove it?

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 31, 2017

☔️ The latest upstream changes (presumably #3878) made this pull request unmergeable. Please resolve the merge conflicts.

@malbarbo malbarbo force-pushed the malbarbo:android-build branch from 836cc38 to ca0bfc9 Mar 31, 2017

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Apr 1, 2017

Thanks for the PR!

Note though that the builds in this repository are going to be retired very soon. We're not actually making releases based on these builds any more right now, so these artifacts will just get gc'd at some point.

It looks like no code changes happened here though? In that case I'd be ok to add a builder to verify that we can keep compiling for android, but otherwise maybe we should hold off until a PR can be made to rust-lang/rust?

@malbarbo

This comment has been minimized.

Copy link
Contributor

malbarbo commented Apr 8, 2017

There is no code change.

In that case I'd be ok to add a builder to verify that we can keep compiling for android

Verify that cargo can be compiled for android (before rust-lang/rust/ is updated) is a good thing.

I made a PR to add android host builders: rust-lang/rust#41149.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Apr 8, 2017

Ok, perhaps we can pare this down to just one Android target? I suspect we won't need to test all android targets in full before changes reach rust-lang/rust

@malbarbo malbarbo force-pushed the malbarbo:android-build branch 2 times, most recently from 3f9a269 to 4eab822 Apr 11, 2017

@malbarbo malbarbo force-pushed the malbarbo:android-build branch from 4eab822 to f723268 Apr 11, 2017

@malbarbo malbarbo changed the title Add android build support Add android build support for armv7 Apr 11, 2017

@malbarbo malbarbo changed the title Add android build support for armv7 Add android build support Apr 11, 2017

@malbarbo

This comment has been minimized.

Copy link
Contributor

malbarbo commented Apr 11, 2017

Ok, perhaps we can pare this down to just one Android target?

That's makes sense. I update the PR.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Apr 12, 2017

@bors: r+

Thanks!

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Apr 12, 2017

📌 Commit f723268 has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Apr 12, 2017

⌛️ Testing commit f723268 with merge a319155...

bors added a commit that referenced this pull request Apr 12, 2017

Auto merge of #3885 - malbarbo:android-build, r=alexcrichton
Add android build support

This add android build support, including openssl.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Apr 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a319155 to master...

@bors bors merged commit f723268 into rust-lang:master Apr 12, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment