Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implementation and CLI-support for `--all-$KIND` flags #3901
This implements #3112.
This means all of the following commands are now possible and meaningful:
The commits try to represent the incremental "propagation" of the new feature:
I intend to follow this up by some other PRs, so please do tell me where I could improve.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
left a comment
@alexcrichton, re: stylistic nit: ah, yes, those braces belong there. Added.
@alexcrichton, @matklad, re: rename: ehh, I personally find
re: readability of diffs: all my new commits can be found at the tip of my branch