Join GitHub today
Allow cargo:rustc-env in build scripts #3929
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
Looking good to me, thanks @Xion!
I wonder if we want to maybe pursue namespacing the env vars though? Righw now cargo exports env vars as
CARGO_* and we may wish to scope the custom env vars here to ensure they don't clash with future significant env vars and such.
As for namespacing, what prefix would not clash with any of the tooling? I was thinking about
On the other hand, I'm not sure such prefixing is necessary nor desirable. Since the values for the env vars are purely in the user's discretion, the names should be too. There may even be some valid use cases for shadowing the
Yeah I think you're right in that we may wish to eschew the prefix, that sounds ok to me.
I think there's some tests failing here related to rustdoc as well? Could you also add tests that execute
cargo doc to ensure that works as well?
On Mon, May 15, 2017 at 11:12 AM, bors ***@***.***> wrote: