Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exec (replace the current process) external subcommands instead of running them as child processes. #3970

Merged
merged 1 commit into from Apr 28, 2017

Conversation

@golddranks
Copy link
Contributor

golddranks commented Apr 28, 2017

This fixes #3959 (tested to be working with my yet-to-be-published subcommand, and tested not to break things with cargo tree and cargo outdated).

…ning them as child processes.
@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Apr 28, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Apr 28, 2017

@bors: r+

Thanks!

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Apr 28, 2017

📌 Commit ca0fc8d has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Apr 28, 2017

⌛️ Testing commit ca0fc8d with merge bb970dc...

bors added a commit that referenced this pull request Apr 28, 2017
exec (replace the current process) external subcommands instead of running them as child processes.

This fixes #3959 (tested to be working with my yet-to-be-published subcommand, and tested not to break things with `cargo tree` and `cargo outdated`).
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Apr 28, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing bb970dc to master...

@bors bors merged commit ca0fc8d into rust-lang:master Apr 28, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.