New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3360 - Allow for features to be either comma or space delimited. #4084

Merged
merged 1 commit into from May 22, 2017

Conversation

Projects
None yet
4 participants
@shiver
Contributor

shiver commented May 22, 2017

This is my attempt at tackling issue #3360.
Hopefully I interpreted the original request correctly and this is what you were looking for.

Any suggestions you might have to improve the submission would be great.
Thanks!

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive May 22, 2017

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive commented May 22, 2017

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton May 22, 2017

Member

Looks great to me, thanks @shiver!

@bors: r+

Member

alexcrichton commented May 22, 2017

Looks great to me, thanks @shiver!

@bors: r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors May 22, 2017

Contributor

📌 Commit 72f8427 has been approved by alexcrichton

Contributor

bors commented May 22, 2017

📌 Commit 72f8427 has been approved by alexcrichton

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors May 22, 2017

Contributor

⌛️ Testing commit 72f8427 with merge 26d1d9d...

Contributor

bors commented May 22, 2017

⌛️ Testing commit 72f8427 with merge 26d1d9d...

bors added a commit that referenced this pull request May 22, 2017

Auto merge of #4084 - shiver:issue-3360, r=alexcrichton
3360 - Allow for features to be either comma or space delimited.

This is my attempt at tackling issue #3360.
Hopefully I interpreted the original request correctly and this is what you were looking for.

Any suggestions you might have to improve the submission would be great.
Thanks!
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors May 22, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 26d1d9d to master...

Contributor

bors commented May 22, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 26d1d9d to master...

@bors bors merged commit 72f8427 into rust-lang:master May 22, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@shiver shiver deleted the shiver:issue-3360 branch May 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment