Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[sources/path] Add gitignore-like pattern matching and warn on mismatches #4270
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
This is a WIP, @alexcrichton.
Writing extensive unit test for the
So, the details for the pattern matching needs some work. Would appreciate feedback on overall direction of the patch.
I'm going to expand the test and cover more cases and make sure
referenced this pull request
Jul 11, 2017
We have fixed
Also, I have updated the warning text to inform users with the context of the change in a few words. Here's an example:
I think we're good to go, if nothing goes wrong with CI. I will submit a diff for Stage 2—to be landed after the next release. Thanks, @alexcrichton, for all the prompt responses and awesome feedbacks!
Uh... because of list of paths not being deterministic, we're getting this kind of failures:
Not sure if it's worth trying to fix this by making the output be deterministic, or just use