New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebased and fixed 4025: Apply --all if workspace is virtual #4335

Merged
merged 6 commits into from Jul 28, 2017

Conversation

Projects
None yet
5 participants
@debris
Contributor

debris commented Jul 27, 2017

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Jul 27, 2017

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@debris debris changed the title from Rebased and fixed 4021: Apply --all if workspace is virtual to Rebased and fixed 4025: Apply --all if workspace is virtual Jul 27, 2017

pub fn bar() {}
"#);
// The order in which foo and bar are built is not guaranteed

This comment has been minimized.

@matklad

matklad Jul 28, 2017

Member

The comment is a bit misleading, because we don' compile bar at all :)

@matklad

matklad Jul 28, 2017

Member

The comment is a bit misleading, because we don' compile bar at all :)

This comment has been minimized.

@debris

debris Jul 28, 2017

Contributor

fixed

@debris

debris Jul 28, 2017

Contributor

fixed

Show outdated Hide outdated tests/build.rs
assert_that(p.cargo_process("build")
.arg("-p").arg("foo"),
execs().with_status(0)
.with_stderr_does_not_contain("[..] Compiling bar v0.1.0 ([..])")

This comment has been minimized.

@matklad

matklad Jul 28, 2017

Member

Let's change this to .with_stderr_does_not_contain("bar") just to make this more robust in case we change the precise output format in the future.

@matklad

matklad Jul 28, 2017

Member

Let's change this to .with_stderr_does_not_contain("bar") just to make this more robust in case we change the precise output format in the future.

@matklad

This comment has been minimized.

Show comment
Hide comment
@matklad

matklad Jul 28, 2017

Member

Looks great now, thanks @debris and @rsertelon!

@bors r+

Member

matklad commented Jul 28, 2017

Looks great now, thanks @debris and @rsertelon!

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 28, 2017

Contributor

📌 Commit f1f3b15 has been approved by matklad

Contributor

bors commented Jul 28, 2017

📌 Commit f1f3b15 has been approved by matklad

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 28, 2017

Contributor

⌛️ Testing commit f1f3b15 with merge 76148e9...

Contributor

bors commented Jul 28, 2017

⌛️ Testing commit f1f3b15 with merge 76148e9...

bors added a commit that referenced this pull request Jul 28, 2017

Auto merge of #4335 - debris:rebased_4021, r=matklad
Rebased and fixed 4025: Apply --all if workspace is virtual

- fixes #4021
- rebased #4025
- fixed issue issue described by @matklad in #4025 (review)
- added test `build_virtual_manifest_one_project` which covers the fix

@matklad matklad added the relnotes label Jul 28, 2017

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 28, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 76148e9 to master...

Contributor

bors commented Jul 28, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 76148e9 to master...

@bors bors merged commit f1f3b15 into rust-lang:master Jul 28, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@debris debris deleted the debris:rebased_4021 branch Jul 28, 2017

@debris debris restored the debris:rebased_4021 branch Jul 28, 2017

@debris debris deleted the debris:rebased_4021 branch Aug 2, 2017

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Nov 3, 2017

Update to 1.21.0
Changelog:
Version 1.21.0 (2017-10-12)
==========================

Language
--------
- [You can now use static references for literals.][43838]
  Example:
  ```rust
  fn main() {
      let x: &'static u32 = &0;
  }
  ```
- [Relaxed path syntax. Optional `::` before `<` is now allowed in all contexts.][43540]
  Example:
  ```rust
  my_macro!(Vec<i32>::new); // Always worked
  my_macro!(Vec::<i32>::new); // Now works
  ```

Compiler
--------
- [Upgraded jemalloc to 4.5.0][43911]
- [Enabled unwinding panics on Redox][43917]
- [Now runs LLVM in parallel during translation phase.][43506]
  This should reduce peak memory usage.

Libraries
---------
- [Generate builtin impls for `Clone` for all arrays and tuples that
  are `T: Clone`][43690]
- [`Stdin`, `Stdout`, and `Stderr` now implement `AsRawFd`.][43459]
- [`Rc` and `Arc` now implement `From<&[T]> where T: Clone`, `From<str>`,
  `From<String>`, `From<Box<T>> where T: ?Sized`, and `From<Vec<T>>`.][42565]

Stabilized APIs
---------------

[`std::mem::discriminant`]

Cargo
-----
- [You can now call `cargo install` with multiple package names][cargo/4216]
- [Cargo commands inside a virtual workspace will now implicitly
  pass `--all`][cargo/4335]
- [Added a `[patch]` section to `Cargo.toml` to handle
  prepublication dependencies][cargo/4123] [RFC 1969]
- [`include` & `exclude` fields in `Cargo.toml` now accept gitignore
  like patterns][cargo/4270]
- [Added the `--all-targets` option][cargo/4400]
- [Using required dependencies as a feature is now deprecated and emits
  a warning][cargo/4364]


Misc
----
- [Cargo docs are moving][43916]
  to [doc.rust-lang.org/cargo](https://doc.rust-lang.org/cargo)
- [The rustdoc book is now available][43863]
  at [doc.rust-lang.org/rustdoc](https://doc.rust-lang.org/rustdoc)
- [Added a preview of RLS has been made available through rustup][44204]
  Install with `rustup component add rls-preview`
- [`std::os` documentation for Unix, Linux, and Windows now appears on doc.rust-lang.org][43348]
  Previously only showed `std::os::unix`.

Compatibility Notes
-------------------
- [Changes in method matching against higher-ranked types][43880] This may cause
  breakage in subtyping corner cases. [A more in-depth explanation is available.][info/43880]
- [rustc's JSON error output's byte position start at top of file.][42973]
  Was previously relative to the rustc's internal `CodeMap` struct which
  required the unstable library `libsyntax` to correctly use.
- [`unused_results` lint no longer ignores booleans][43728]

[42565]: rust-lang/rust#42565
[42973]: rust-lang/rust#42973
[43348]: rust-lang/rust#43348
[43459]: rust-lang/rust#43459
[43506]: rust-lang/rust#43506
[43540]: rust-lang/rust#43540
[43690]: rust-lang/rust#43690
[43728]: rust-lang/rust#43728
[43838]: rust-lang/rust#43838
[43863]: rust-lang/rust#43863
[43880]: rust-lang/rust#43880
[43911]: rust-lang/rust#43911
[43916]: rust-lang/rust#43916
[43917]: rust-lang/rust#43917
[44204]: rust-lang/rust#44204
[cargo/4123]: rust-lang/cargo#4123
[cargo/4216]: rust-lang/cargo#4216
[cargo/4270]: rust-lang/cargo#4270
[cargo/4335]: rust-lang/cargo#4335
[cargo/4364]: rust-lang/cargo#4364
[cargo/4400]: rust-lang/cargo#4400
[RFC 1969]: rust-lang/rfcs#1969
[info/43880]: rust-lang/rust#44224 (comment)
[`std::mem::discriminant`]: https://doc.rust-lang.org/std/mem/fn.discriminant.html

SimonSapin added a commit to SimonSapin/cargo that referenced this pull request Nov 28, 2017

SimonSapin added a commit to SimonSapin/cargo that referenced this pull request Nov 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment