Skip to content

/cargo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When uplifting directories, symlink them instead of hard-link them. #4672

Merged
merged 1 commit into from Oct 29, 2017

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@kennytm @rust-highfive @alexcrichton @bors
@kennytm
Copy link
Member

kennytm commented Oct 28, 2017

Fixes #4671.
@kennytm
When uplifting directories, symlink them instead of hard-link them. 
Fixes #4671.
Verified
This commit was signed with a verified signature.
@kennytm kennytm
GPG key ID: FEF6C8051D0E013C Learn about signing commits
Loading status checks…
53e90d7

@rust-highfive rust-highfive assigned alexcrichton Oct 28, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link

rust-highfive commented Oct 28, 2017

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Oct 29, 2017

@bors: r+

Thanks!
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 29, 2017

📌 Commit 53e90d7 has been approved by alexcrichton
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 29, 2017

⌛️ Testing commit 53e90d7 with merge 859c230...

bors added a commit that referenced this pull request Oct 29, 2017

@bors
Auto merge of #4672 - kennytm:fix-4671, r=alexcrichton 
When uplifting directories, symlink them instead of hard-link them.

Fixes #4671.
Loading status checks…
859c230
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 29, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 859c230 to master...

@bors bors merged commit 53e90d7 into rust-lang:master Oct 29, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@kennytm kennytm deleted the kennytm:fix-4671 branch Oct 29, 2017

kennytm added a commit to kennytm/rust that referenced this pull request Oct 29, 2017

@kennytm
Update cargo. 
Brings in rust-lang/cargo#4672, unbreaks nightly on macOS APFS.
Verified
This commit was signed with a verified signature.
@kennytm kennytm
GPG key ID: FEF6C8051D0E013C Learn about signing commits
30828c5

@kennytm kennytm referenced this pull request Oct 29, 2017

Merged

Update cargo. #45618

bors added a commit to rust-lang/rust that referenced this pull request Oct 30, 2017

@bors
Auto merge of #45618 - kennytm:update-cargo, r=alexcrichton 
Update cargo.

Brings in rust-lang/cargo#4672, unbreaks nightly on macOS APFS.

Fixes #45607.

r? @alexcrichton
Loading status checks…
875ec8d

Xanewok added a commit to Xanewok/rust that referenced this pull request Oct 30, 2017

@kennytm @Xanewok
Update cargo. 
Brings in rust-lang/cargo#4672, unbreaks nightly on macOS APFS.
973d41b

@kennytm kennytm referenced this pull request Nov 4, 2017

Closed

"failed to remove `.dSYM`" when cross compiling to 32-bit macOS #4699

@kennytm kennytm referenced this pull request Nov 22, 2017

Merged

[beta] When uplifting directories, symlink them instead of hard-link them. #4739

bors added a commit that referenced this pull request Nov 22, 2017

@bors
Auto merge of #4739 - kennytm:backport-4672, r=matklad 
[beta] When uplifting directories, symlink them instead of hard-link them.

Backport of #4672 to 1.22 (cargo 0.23)

The current stable RC (cee38cd) contains #4616 *but not* #4672. Without the latter it is known to cause #4671 on APFS (enabled by default on macOS 10.13 "High Sierra").

The issue was found by kpy3 on https://internals.rust-lang.org/t/rust-1-22-0-prerelease-testing/6282/2.
Loading status checks…
61fa024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.